content/browser/renderer_host/render_widget_host_view_android.h - Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_android.h

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/render_widget_host_impl.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_android.h

diff --git a/content/browser/renderer_host/render_widget_host_view_android.h b/content/browser/renderer_host/render_widget_host_view_android.h

index 05cc928494ef00e04bbf825b54a931ca60d10ae0..982da1c78e28ca2e791aa49c3543c70a23d88328 100644

--- a/content/browser/renderer_host/render_widget_host_view_android.h

+++ b/content/browser/renderer_host/render_widget_host_view_android.h

@@ -105,10 +105,8 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

float GetTopControlsHeight() const override;

void UpdateCursor(const WebCursor& cursor) override;

void SetIsLoading(bool is_loading) override;

- void TextInputTypeChanged(ui::TextInputType type,

- ui::TextInputMode input_mode,

- bool can_compose_inline,

- int flags) override;

+ void TextInputStateChanged(

+ const ViewHostMsg_TextInputState_Params& params) override;

void ImeCancelComposition() override;

void ImeCompositionRangeChanged(

const gfx::Range& range,

@@ -212,7 +210,6 @@ class CONTENT_EXPORT RenderWidgetHostViewAndroid

void SendMouseWheelEvent(const blink::WebMouseWheelEvent& event);

void SendGestureEvent(const blink::WebGestureEvent& event);

- void OnTextInputStateChanged(const ViewHostMsg_TextInputState_Params& params);

void OnDidChangeBodyBackgroundColor(SkColor color);

void OnStartContentIntent(const GURL& content_url);

void OnSetNeedsBeginFrames(bool enabled);