Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(615)

Side by Side Diff: content/browser/browser_plugin/browser_plugin_guest.h

Issue 1249013005: Merge ViewHostMsg_TextInputTypeChanged and ViewHostMsg_TextInputStateChanged into one. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // A BrowserPluginGuest is the browser side of a browser <--> embedder 5 // A BrowserPluginGuest is the browser side of a browser <--> embedder
6 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder 6 // renderer channel. A BrowserPlugin (a WebPlugin) is on the embedder
7 // renderer side of browser <--> embedder renderer communication. 7 // renderer side of browser <--> embedder renderer communication.
8 // 8 //
9 // BrowserPluginGuest lives on the UI thread of the browser process. Any 9 // BrowserPluginGuest lives on the UI thread of the browser process. Any
10 // messages about the guest render process that the embedder might be interested 10 // messages about the guest render process that the embedder might be interested
(...skipping 26 matching lines...) Expand all
37 #include "third_party/WebKit/public/web/WebDragStatus.h" 37 #include "third_party/WebKit/public/web/WebDragStatus.h"
38 #include "third_party/WebKit/public/web/WebInputEvent.h" 38 #include "third_party/WebKit/public/web/WebInputEvent.h"
39 #include "ui/base/ime/text_input_mode.h" 39 #include "ui/base/ime/text_input_mode.h"
40 #include "ui/base/ime/text_input_type.h" 40 #include "ui/base/ime/text_input_type.h"
41 #include "ui/gfx/geometry/rect.h" 41 #include "ui/gfx/geometry/rect.h"
42 42
43 struct BrowserPluginHostMsg_Attach_Params; 43 struct BrowserPluginHostMsg_Attach_Params;
44 struct FrameHostMsg_CompositorFrameSwappedACK_Params; 44 struct FrameHostMsg_CompositorFrameSwappedACK_Params;
45 struct FrameHostMsg_ReclaimCompositorResources_Params; 45 struct FrameHostMsg_ReclaimCompositorResources_Params;
46 struct FrameMsg_CompositorFrameSwapped_Params; 46 struct FrameMsg_CompositorFrameSwapped_Params;
47 struct ViewHostMsg_TextInputState_Params;
47 48
48 #if defined(OS_MACOSX) 49 #if defined(OS_MACOSX)
49 struct FrameHostMsg_ShowPopup_Params; 50 struct FrameHostMsg_ShowPopup_Params;
50 #endif 51 #endif
51 52
52 namespace cc { 53 namespace cc {
53 class CompositorFrame; 54 class CompositorFrame;
54 struct SurfaceId; 55 struct SurfaceId;
55 struct SurfaceSequence; 56 struct SurfaceSequence;
56 } // namespace cc 57 } // namespace cc
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 // compositing mode, see CCLayerTreeHost::setVisible). 328 // compositing mode, see CCLayerTreeHost::setVisible).
328 // 329 //
329 // Additionally, it will slow down Javascript execution and garbage 330 // Additionally, it will slow down Javascript execution and garbage
330 // collection. See RenderThreadImpl::IdleHandler (executed when hidden) and 331 // collection. See RenderThreadImpl::IdleHandler (executed when hidden) and
331 // RenderThreadImpl::IdleHandlerInForegroundTab (executed when visible). 332 // RenderThreadImpl::IdleHandlerInForegroundTab (executed when visible).
332 void OnSetVisibility(int instance_id, bool visible); 333 void OnSetVisibility(int instance_id, bool visible);
333 void OnUnlockMouse(); 334 void OnUnlockMouse();
334 void OnUnlockMouseAck(int instance_id); 335 void OnUnlockMouseAck(int instance_id);
335 void OnUpdateGeometry(int instance_id, const gfx::Rect& view_rect); 336 void OnUpdateGeometry(int instance_id, const gfx::Rect& view_rect);
336 337
337 void OnTextInputTypeChanged(ui::TextInputType type, 338 void OnTextInputStateChanged(
338 ui::TextInputMode input_mode, 339 const ViewHostMsg_TextInputState_Params& params);
339 bool can_compose_inline,
340 int flags);
341 void OnImeSetComposition( 340 void OnImeSetComposition(
342 int instance_id, 341 int instance_id,
343 const std::string& text, 342 const std::string& text,
344 const std::vector<blink::WebCompositionUnderline>& underlines, 343 const std::vector<blink::WebCompositionUnderline>& underlines,
345 int selection_start, 344 int selection_start,
346 int selection_end); 345 int selection_end);
347 void OnImeConfirmComposition( 346 void OnImeConfirmComposition(
348 int instance_id, 347 int instance_id,
349 const std::string& text, 348 const std::string& text,
350 bool keep_selection); 349 bool keep_selection);
(...skipping 108 matching lines...) Expand 10 before | Expand all | Expand 10 after
459 // Weak pointer used to ask GeolocationPermissionContext about geolocation 458 // Weak pointer used to ask GeolocationPermissionContext about geolocation
460 // permission. 459 // permission.
461 base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_; 460 base::WeakPtrFactory<BrowserPluginGuest> weak_ptr_factory_;
462 461
463 DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest); 462 DISALLOW_COPY_AND_ASSIGN(BrowserPluginGuest);
464 }; 463 };
465 464
466 } // namespace content 465 } // namespace content
467 466
468 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_ 467 #endif // CONTENT_BROWSER_BROWSER_PLUGIN_BROWSER_PLUGIN_GUEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698