Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: Source/core/inspector/InjectedScriptSource.js

Issue 1249013002: DevTools: simplify setScriptSource and restartFrame return values (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * Copyright (C) 2013 Google Inc. All rights reserved. 3 * Copyright (C) 2013 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 941 matching lines...) Expand 10 before | Expand all | Expand 10 after
952 /** 952 /**
953 * @param {!JavaScriptCallFrame} topCallFrame 953 * @param {!JavaScriptCallFrame} topCallFrame
954 * @param {string} callFrameId 954 * @param {string} callFrameId
955 * @return {*} 955 * @return {*}
956 */ 956 */
957 restartFrame: function(topCallFrame, callFrameId) 957 restartFrame: function(topCallFrame, callFrameId)
958 { 958 {
959 var callFrame = this._callFrameForId(topCallFrame, callFrameId); 959 var callFrame = this._callFrameForId(topCallFrame, callFrameId);
960 if (!callFrame) 960 if (!callFrame)
961 return "Could not find call frame with given id"; 961 return "Could not find call frame with given id";
962 var result = callFrame.restart(); 962 return callFrame.restart();
963 if (result === false)
964 result = "Restart frame is not supported";
965 return result;
966 }, 963 },
967 964
968 /** 965 /**
969 * @param {!JavaScriptCallFrame} topCallFrame 966 * @param {!JavaScriptCallFrame} topCallFrame
970 * @param {string} callFrameId 967 * @param {string} callFrameId
971 * @return {*} a stepIn position array ready for protocol JSON or a string e rror 968 * @return {*} a stepIn position array ready for protocol JSON or a string e rror
972 */ 969 */
973 getStepInPositions: function(topCallFrame, callFrameId) 970 getStepInPositions: function(topCallFrame, callFrameId)
974 { 971 {
975 var callFrame = this._callFrameForId(topCallFrame, callFrameId); 972 var callFrame = this._callFrameForId(topCallFrame, callFrameId);
(...skipping 974 matching lines...) Expand 10 before | Expand all | Expand 10 after
1950 */ 1947 */
1951 _logEvent: function(event) 1948 _logEvent: function(event)
1952 { 1949 {
1953 inspectedGlobalObject.console.log(event.type, event); 1950 inspectedGlobalObject.console.log(event.type, event);
1954 } 1951 }
1955 } 1952 }
1956 1953
1957 injectedScript._commandLineAPIImpl = new CommandLineAPIImpl(); 1954 injectedScript._commandLineAPIImpl = new CommandLineAPIImpl();
1958 return injectedScript; 1955 return injectedScript;
1959 }) 1956 })
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698