Send Feedback Experiment

chrome/browser/ui/webui/help/help_handler.cc

Index: chrome/browser/ui/webui/help/help_handler.cc
diff --git a/chrome/browser/ui/webui/help/help_handler.cc b/chrome/browser/ui/webui/help/help_handler.cc
index 9f5dce9fb4c341ae4f8cf2bccf5544e9cc65ac4b..89b3a41eec287369ccdc9aa0475dccb7bad3b401 100644
--- a/chrome/browser/ui/webui/help/help_handler.cc
+++ b/chrome/browser/ui/webui/help/help_handler.cc
@@ -20,6 +20,7 @@
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/chrome_pages.h"
+#include "chrome/browser/ui/send_feedback_experiment.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/url_constants.h"
@@ -53,6 +54,8 @@ using content::BrowserThread;
 
 namespace {
 
+const char kResourceReportIssue[] = "reportAnIssue";
+
 // Returns the browser version as a string.
 string16 BuildBrowserVersionString() {
   chrome::VersionInfo version_info;
@@ -139,7 +142,7 @@ void HelpHandler::GetLocalizedValues(content::WebUIDataSource* source) {
     { "updating", IDS_UPGRADE_UPDATING },
     { "updateAlmostDone", IDS_UPGRADE_SUCCESSFUL_RELAUNCH },
     { "getHelpWithChrome", IDS_GET_HELP_USING_CHROME },
-    { "reportAnIssue", IDS_REPORT_AN_ISSUE },
+    { kResourceReportIssue, IDS_REPORT_AN_ISSUE },
 #if defined(OS_CHROMEOS)
     { "platform", IDS_PLATFORM_LABEL },
     { "firmware", IDS_ABOUT_PAGE_FIRMWARE },
@@ -161,6 +164,15 @@ void HelpHandler::GetLocalizedValues(content::WebUIDataSource* source) {
 #endif
   };
 
+  if (chrome::UseAlternateSendFeedbackText()) {
+    // Field trial to substitute "Report an Issue" with "Send Feedback".
+    // (crbug.com/169339)
+    for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resources); ++i) {
+      if (std::string(kResourceReportIssue) == resources[i].name)

[sky, 2013/03/22 03:58:34]

Could you remove the string construction outside the loop so it isn't done on
every iteration?

+        resources[i].ids = IDS_SEND_FEEDBACK;
+    }
+  }
+
   for (size_t i = 0; i < ARRAYSIZE_UNSAFE(resources); ++i) {
     source->AddString(resources[i].name,
                       l10n_util::GetStringUTF16(resources[i].ids));