Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 12490004: Add an RPC to LLC.nexe to init with appended flags (vs set all flags). (Closed)

Created:
7 years, 9 months ago by jvoung (off chromium)
Modified:
7 years, 9 months ago
Reviewers:
sehr, Derek Schuff
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Add an RPC to LLC.nexe to init with appended flags (vs set all flags). This will take the default flags and append any extra flags. For now, this is only intended to support -O in the browser, and perhaps -mcpu=.*, -mattr=. We move the tuning parameters like -mcpu out of the default, so that a user does not end up setting the -mcpu more than once (which is disallowed). What does go into the default is -mtriple, which we may want to hard-code into the build somehow (but it's not yet clear how to do that cleanly). That way, a user does not need to specify that portion. We also hardcode the -sfi-* flags. Sort of tested by: https://codereview.chromium.org/12459004/ BUG= https://code.google.com/p/nativeclient/issues/detail?id=3325 Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=79da56a

Patch Set 1 #

Patch Set 2 : force mcpu sometimes #

Total comments: 2

Patch Set 3 : Had -> Has #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -18 lines) Patch
M tools/llc/nacl_file.cpp View 1 2 7 chunks +98 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jvoung (off chromium)
7 years, 9 months ago (2013-03-05 23:31:14 UTC) #1
Derek Schuff
lgtm https://codereview.chromium.org/12490004/diff/3001/tools/llc/nacl_file.cpp File tools/llc/nacl_file.cpp (right): https://codereview.chromium.org/12490004/diff/3001/tools/llc/nacl_file.cpp#newcode165 tools/llc/nacl_file.cpp:165: bool HadCPUOverride(string_vector* vec) { s/Had/Has?
7 years, 9 months ago (2013-03-06 17:45:27 UTC) #2
jvoung (off chromium)
https://codereview.chromium.org/12490004/diff/3001/tools/llc/nacl_file.cpp File tools/llc/nacl_file.cpp (right): https://codereview.chromium.org/12490004/diff/3001/tools/llc/nacl_file.cpp#newcode165 tools/llc/nacl_file.cpp:165: bool HadCPUOverride(string_vector* vec) { On 2013/03/06 17:45:27, Derek Schuff ...
7 years, 9 months ago (2013-03-06 18:24:43 UTC) #3
jvoung (off chromium)
7 years, 9 months ago (2013-03-06 19:30:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r79da56a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698