Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1248873002: Revert of Make AXProviderTest.HelloWorld bail without oopifs. (Closed)

Created:
5 years, 5 months ago by msw
Modified:
5 years, 5 months ago
Reviewers:
jam, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make AXProviderTest.HelloWorld bail without oopifs. (patchset #1 id:1 of https://codereview.chromium.org/1224103002/) Reason for revert: Sadrul landed a fix for the flaky timeouts: https://codereview.chromium.org/1228173003 Bailing didn't resolve these flakes anyway. Original issue's description: > Make AXProviderTest.HelloWorld bail without oopifs. > > This test times out flakily without oopifs enabled. > Effectively disable the test without oopifs for now. > This should unblock running apptests on the CQ/main. > > BUG=504917 > TEST=Test isn't run without oopifs for now... > R=jam@chromium.org > TBR=sky@chromium.org > > Committed: https://crrev.com/427c2f36770711c369a85f56c4a63b4036e735a9 > Cr-Commit-Position: refs/heads/master@{#338073} TBR=jam@chromium.org,sky@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504917 Committed: https://crrev.com/6517a6cf6e09242c553a28e5c175cb59920a694e Cr-Commit-Position: refs/heads/master@{#339722}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M components/html_viewer/ax_provider_apptest.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Created Revert of Make AXProviderTest.HelloWorld bail without oopifs.
5 years, 5 months ago (2015-07-21 19:41:36 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248873002/1
5 years, 5 months ago (2015-07-21 19:42:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 19:44:14 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:49:25 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6517a6cf6e09242c553a28e5c175cb59920a694e
Cr-Commit-Position: refs/heads/master@{#339722}

Powered by Google App Engine
This is Rietveld 408576698