Issue 1248823005: Re-add deprecation warnings for device orientation and device motion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1248823005: Re-add deprecation warnings for device orientation and device motion. (Closed)

Created:
5 years, 5 months ago by jww

Modified:
5 years, 5 months ago

Reviewers:
philipj_slow

CC:
blink-reviews, mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, Inactive, timvolodine

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Re-add deprecation warnings for device orientation and device motion. As per the plan to deprecate powerful features on insecure origins (https://goo.gl/rStTGz), this reimplements the deprecation console warnings for device orientation and motion on insecure origins. This was implemented a while ago, but the numbers were so high due to a bug, that it was decided to wait to implement the deprecation warnings until a time when and if corrected metrics showed a lower rate of use. Now that the lower rate of use is hovering around 0.4% of page loads for each, this re-implements the warnings. R=philipj@opera.com BUG=481604 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199299

Patch Set 1 #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/frame/UseCounter.cpp	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	Source/modules/device_orientation/DeviceMotionController.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/device_orientation/DeviceOrientationController.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248823005/1

5 years, 5 months ago (2015-07-22 08:37:25 UTC) #4

commit-bot: I haz the power

5 years, 5 months ago (2015-07-22 09:59:34 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=199299

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages