Phase 3: Implement New Task Manager Flag in about:flags.

Phase 3: Implement New Task Manager Flag in about:flags.

Adding a flag to enable the use of the newly rewritten implementation of
the task manager.

BUG=471006
Committed: https://crrev.com/a5fa441790fedbc583832a5827ac73a4748e6ab1
Cr-Commit-Position: refs/heads/master@{#339806}

[afakhry, 2015-07-21 21:20:23]

afakhry@chromium.org changed reviewers:
+ asvitkine@chromium.org, nick@chromium.org, thestig@chromium.org

[afakhry, 2015-07-21 21:20:23]

Hi we're adding a flag to switch between the old and new task manager
implementations. Please review this CL:
thestig@chromium.org:
 chrome/app/generated_resources.grd
 chrome/browser/about_flags.cc
 chrome/common/chrome_switches.cc
 chrome/common/chrome_switches.h

asvitkine@chromium.org:
 tools/metrics/histograms/histograms.xml

[Alexei Svitkine (slow), 2015-07-21 21:21:44]

lgtm

[Lei Zhang, 2015-07-21 21:28:54]

https://codereview.chromium.org/1248823004/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1248823004/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:7019: +      <message
name="IDS_FLAGS_ENABLE_NEW_TASK_MANAGER_NAME" desc="Name of the flag to enable
the new implementation of the task manager.">
Should this be inside <if expr="enable_task_manager"> ?

about_flags.cc would need to be updated as well.

https://codereview.chromium.org/1248823004/diff/1/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/1248823004/diff/1/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:1375: if
(base::CommandLine::ForCurrentProcess()->HasSwitch(kEnableNewTaskManager))
Since you are not doing anything fancy, just:

return base::CommandLine::ForCurrentProcess()->HasSwitch(kEnableNewTaskManager);

[afakhry, 2015-07-21 22:16:13]

https://codereview.chromium.org/1248823004/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/1248823004/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:7019: +      <message
name="IDS_FLAGS_ENABLE_NEW_TASK_MANAGER_NAME" desc="Name of the flag to enable
the new implementation of the task manager.">
On 2015/07/21 21:28:54, Lei Zhang wrote:
> Should this be inside <if expr="enable_task_manager"> ?
> 
> about_flags.cc would need to be updated as well.

Done.

https://codereview.chromium.org/1248823004/diff/1/chrome/common/chrome_switch...
File chrome/common/chrome_switches.cc (right):

https://codereview.chromium.org/1248823004/diff/1/chrome/common/chrome_switch...
chrome/common/chrome_switches.cc:1375: if
(base::CommandLine::ForCurrentProcess()->HasSwitch(kEnableNewTaskManager))
On 2015/07/21 21:28:54, Lei Zhang wrote:
> Since you are not doing anything fancy, just:
> 
> return
base::CommandLine::ForCurrentProcess()->HasSwitch(kEnableNewTaskManager);

Done.

[its_nick_at_chromium_org, 2015-07-21 22:18:21]

ncarter@google.com changed reviewers:
+ ncarter@google.com

[its_nick_at_chromium_org, 2015-07-21 22:18:21]

lgtm but I agree with thestig@ about not including the resources on android
(it's probably better to use ENABLE_TASK_MANAGER than kOsDesktop, though they
accomplish the same thing)

[ncarter (slow), 2015-07-21 22:20:07]

nick@chromium.org changed reviewers:
- ncarter@google.com

[ncarter (slow), 2015-07-21 22:20:08]

newest patch set lgtm

[Lei Zhang, 2015-07-21 22:59:36]

lgtm

[afakhry, 2015-07-21 23:07:12]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2015-07-21 23:07:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/1248823004/#ps20001
(title: "flag is available only when ENABLE_TASK_MANAGER=1")

[commit-bot: I haz the power, 2015-07-21 23:08:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1248823004/20001

[commit-bot: I haz the power, 2015-07-22 00:56:59]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-22 00:57:47]

Patchset 2 (id:??) landed as
https://crrev.com/a5fa441790fedbc583832a5827ac73a4748e6ab1
Cr-Commit-Position: refs/heads/master@{#339806}