Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1248743003: [turbofan] Get rid of overly abstract SimplifiedGraphBuilder. (Closed)

Created:
5 years, 5 months ago by Michael Starzinger
Modified:
5 years, 5 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Get rid of overly abstract SimplifiedGraphBuilder. R=titzer@chromium.org Committed: https://crrev.com/1c43c3ae73fe2f1dddd631869d56f120e352858b Cr-Commit-Position: refs/heads/master@{#29792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -244 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M test/cctest/compiler/graph-builder-tester.h View 5 chunks +166 lines, -4 lines 0 comments Download
D test/cctest/compiler/simplified-graph-builder.h View 1 chunk +0 lines, -151 lines 0 comments Download
D test/cctest/compiler/simplified-graph-builder.cc View 1 chunk +0 lines, -87 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 5 months ago (2015-07-22 15:13:35 UTC) #1
titzer
lgtm
5 years, 5 months ago (2015-07-22 15:20:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248743003/1
5 years, 5 months ago (2015-07-22 15:37:54 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-22 18:28:29 UTC) #5
commit-bot: I haz the power
5 years, 5 months ago (2015-07-22 18:28:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1c43c3ae73fe2f1dddd631869d56f120e352858b
Cr-Commit-Position: refs/heads/master@{#29792}

Powered by Google App Engine
This is Rietveld 408576698