Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: pkg/analysis_server/test/src/watch_manager_test.dart

Issue 1248723002: Fix watch manager tests (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/src/watch_manager_test.dart
diff --git a/pkg/analysis_server/test/src/watch_manager_test.dart b/pkg/analysis_server/test/src/watch_manager_test.dart
index 8d1c4e2102528cafeeae90b96e752b8ef002ddab..a8d885d63eb8e105358b8c3e6a2eff471a248703 100644
--- a/pkg/analysis_server/test/src/watch_manager_test.dart
+++ b/pkg/analysis_server/test/src/watch_manager_test.dart
@@ -96,7 +96,7 @@ class WatchManagerTest {
await _expectEvent(ChangeType.ADD, newFile1.path, [topToken]);
File newFile2 = provider.newFile('/a/b/c/d/lib.dart', '');
- _expectEvent(ChangeType.ADD, newFile2.path, [topToken, childToken]);
+ return _expectEvent(ChangeType.ADD, newFile2.path, [topToken, childToken]);
}
Future test_addFolder_singleFolder_multipleTokens() {
@@ -119,7 +119,7 @@ class WatchManagerTest {
await _expectEvent(ChangeType.ADD, newFolder.path, [token]);
File newFile = provider.newFile('/a/b/c/lib.dart', '');
- _expectEvent(ChangeType.ADD, newFile.path, [token]);
+ return _expectEvent(ChangeType.ADD, newFile.path, [token]);
}
Future test_addFolder_unrelatedFolders() async {
@@ -134,7 +134,7 @@ class WatchManagerTest {
await _expectEvent(ChangeType.ADD, newFile1.path, [token1]);
File newFile2 = provider.newFile('/c/d/lib.dart', '');
- _expectEvent(ChangeType.ADD, newFile2.path, [token2]);
+ return _expectEvent(ChangeType.ADD, newFile2.path, [token2]);
}
void test_creation() {
@@ -153,15 +153,6 @@ class WatchManagerTest {
return _expectEvent(ChangeType.ADD, newFile.path, [token1]);
}
- Future test_removeFolder_unadded() {
- Folder folder = provider.getFolder('/a/b');
- Token token = new Token('token');
- expect(() => manager.removeFolder(folder, token), throws);
-
- provider.newFile('/a/b/lib.dart', '');
- return _expectNoEvent();
- }
-
Future test_removeFolder_withChildren() async {
Folder topFolder = provider.getFolder('/a/b');
Folder childFolder = provider.getFolder('/a/b/c/d');
@@ -175,7 +166,7 @@ class WatchManagerTest {
await _expectEvent(ChangeType.ADD, newFile.path, [childToken]);
provider.newFile('/a/b/lib.dart', '');
- _expectNoEvent();
+ return _expectNoEvent();
}
Future test_removeFolder_withNoChildren() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698