Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: ui/ozone/public/client_native_pixmap_factory.h

Issue 1248713002: ozone: ClientPixmapManager passes VGEM fd from browser to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: scoped_ptr<base::ScopedFD> instead of base::ScopedFD* Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/public/client_native_pixmap_factory.h
diff --git a/ui/ozone/public/client_native_pixmap_factory.h b/ui/ozone/public/client_native_pixmap_factory.h
index a5d58e16c6e1018e20e628094165d076c9478211..e5ba280f53487e3127f5e9e2751e9a0b55c0d0ac 100644
--- a/ui/ozone/public/client_native_pixmap_factory.h
+++ b/ui/ozone/public/client_native_pixmap_factory.h
@@ -7,6 +7,7 @@
#include <vector>
+#include "base/files/scoped_file.h"
#include "base/memory/scoped_ptr.h"
#include "ui/gfx/buffer_types.h"
#include "ui/ozone/ozone_export.h"
@@ -17,12 +18,6 @@ struct NativePixmapHandle;
class Size;
}
-namespace base {
-
-struct FileDescriptor;
-
-} // namespace base
-
namespace ui {
// The Ozone interface allows external implementations to hook into Chromium to
@@ -36,6 +31,12 @@ class OZONE_EXPORT ClientNativePixmapFactory {
virtual ~ClientNativePixmapFactory();
+ // Open VGEM device file.
+ virtual scoped_ptr<base::ScopedFD> OpenVgemFD() const = 0;
spang 2015/08/17 18:03:41 Just base::ScopedFD.
+
+ // Set VGEM device file.
+ virtual void SetVgemFD(scoped_ptr<base::ScopedFD> vgem_fd) = 0;
spang 2015/08/17 18:03:41 I'd prefer virtual void Initialize(base::ScopedFD
dshwang 2015/08/18 14:14:39 good idea. Done.
+
struct Configuration {
gfx::BufferFormat format;
gfx::BufferUsage usage;

Powered by Google App Engine
This is Rietveld 408576698