ozone: ClientPixmapManager passes VGEM fd from browser to renderer.

ui/ozone/public/client_native_pixmap_factory.h

Index: ui/ozone/public/client_native_pixmap_factory.h
diff --git a/ui/ozone/public/client_native_pixmap_factory.h b/ui/ozone/public/client_native_pixmap_factory.h
index a5d58e16c6e1018e20e628094165d076c9478211..aeef2b5371d3360c202a96037f870f575da1764c 100644
--- a/ui/ozone/public/client_native_pixmap_factory.h
+++ b/ui/ozone/public/client_native_pixmap_factory.h
@@ -7,6 +7,7 @@
 
 #include <vector>
 
+#include "base/files/scoped_file.h"
 #include "base/memory/scoped_ptr.h"
 #include "ui/gfx/buffer_types.h"
 #include "ui/ozone/ozone_export.h"
@@ -17,12 +18,6 @@ struct NativePixmapHandle;
 class Size;
 }
 
-namespace base {
-
-struct FileDescriptor;
-
-}  // namespace base
-
 namespace ui {
 
 // The Ozone interface allows external implementations to hook into Chromium to
@@ -36,6 +31,12 @@ class OZONE_EXPORT ClientNativePixmapFactory {
 
   virtual ~ClientNativePixmapFactory();
 
+  // Open VGEM device file. A caller takes ownership of the file descriptor.
+  virtual base::ScopedFD OpenVgemFD() const = 0;

[reveman, 2015/08/14 16:53:16]

doesn't the return type have to be scoped_ptr<base::ScopedFD>?

[dshwang, 2015/08/17 10:28:55]

Done.

[spang, 2015/08/17 18:03:41]

Plain base::ScopedFD is correct, it's not necessary to wrap with scoped_ptr<>
because ScopedFD already transfers ownership like a scoped_ptr<> would.

[dshwang, 2015/08/18 14:14:39]

Done. Thx for explaining.

+
+  // Set VGEM device file. This takes ownership of the file descriptor.
+  virtual void SetVgemFD(base::ScopedFD* vgem_fd) = 0;

[reveman, 2015/08/14 16:53:17]

scoped_ptr<base::ScopedFD> if passing ownership?

[dshwang, 2015/08/17 10:28:55]

That's good idea, although it's the first time that scoped_ptr<base::ScopedFD>
is used in whole source. Done.

+
   struct Configuration {
     gfx::BufferFormat format;
     gfx::BufferUsage usage;