Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Unified Diff: ui/ozone/public/client_native_pixmap_factory.h

Issue 1248713002: ozone: ClientPixmapManager passes VGEM fd from browser to renderer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rename to ClientNativePixmapFactory Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/ozone/public/client_native_pixmap_factory.h
diff --git a/ui/ozone/public/client_native_pixmap_factory.h b/ui/ozone/public/client_native_pixmap_factory.h
index 1f216018d19b99818273b6db1bf2e482cb3ea4b4..9db6842fc2f20c1cfe308851dc8f011da0ccbb5f 100644
--- a/ui/ozone/public/client_native_pixmap_factory.h
+++ b/ui/ozone/public/client_native_pixmap_factory.h
@@ -28,7 +28,8 @@ class OZONE_EXPORT ClientNativePixmapFactory {
static ClientNativePixmapFactory* GetInstance();
static void SetInstance(ClientNativePixmapFactory* instance);
- static scoped_ptr<ClientNativePixmapFactory> Create();
+ static scoped_ptr<ClientNativePixmapFactory> Create(
+ const base::FileDescriptor& virtual_device);
virtual ~ClientNativePixmapFactory();
@@ -51,6 +52,8 @@ class OZONE_EXPORT ClientNativePixmapFactory {
protected:
ClientNativePixmapFactory();
+ virtual void Initialize(const base::FileDescriptor& virtual_device) = 0;
reveman 2015/08/13 18:05:28 if this can't fail, why not pass the fd to the cto
dshwang 2015/08/14 12:40:03 Replace it with SetVgemFD()
+
private:
DISALLOW_COPY_AND_ASSIGN(ClientNativePixmapFactory);
};

Powered by Google App Engine
This is Rietveld 408576698