ozone: ClientPixmapManager passes VGEM fd from browser to renderer.

content/browser/gpu/browser_client_native_pixmap_factory_ozone.h

Index: content/browser/gpu/browser_client_native_pixmap_factory_ozone.h
diff --git a/content/browser/gpu/browser_client_native_pixmap_factory_ozone.h b/content/browser/gpu/browser_client_native_pixmap_factory_ozone.h
new file mode 100644
index 0000000000000000000000000000000000000000..70863c6140b99040c82da41454d8740e60933ecc
--- /dev/null
+++ b/content/browser/gpu/browser_client_native_pixmap_factory_ozone.h
@@ -0,0 +1,45 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CONTENT_BROWSER_GPU_BROWSER_CLIENT_NATIVE_PIXMAP_FACTORY_OZONE_H_
+#define CONTENT_BROWSER_GPU_BROWSER_CLIENT_NATIVE_PIXMAP_FACTORY_OZONE_H_
+
+#include "base/file_descriptor_posix.h"
+#include "base/memory/scoped_ptr.h"
+#include "ipc/ipc_sender.h"
+#include "ui/ozone/public/client_native_pixmap_factory.h"
+
+namespace content {
+
+class BrowserClientNativePixmapFactory : public ui::ClientNativePixmapFactory {

[reveman, 2015/08/13 18:05:28]

This class doesn't seem useful to me. Afaict, it's just a large wrapper around
sending one IPC message to the renderer with the vgem_fd.

We can replace all this with a few lines of code in RenderProcessHostImpl. In
addition to reducing code, I think it will also make the code easier to
understand and easier to review and make sure it does the right thing as we'd
follow the pattern already put in place for IOSurface tokens.

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

[dshwang, 2015/08/14 12:40:03]

Thank you for explaining. I removed (Browser|Child)XXXFactory wrappers.
I didn't want RenderProcessHostImpl to do more thing, but it looks
over-generalized. One thing more in RenderProcessHostImpl is practically
acceptable compared to bloating code.

+ public:
+  static BrowserClientNativePixmapFactory* GetInstance();
+  ~BrowserClientNativePixmapFactory() override;
+
+  // Send virtual device file descriptor to child process.
+  void SendVirtualDevice(IPC::Sender* sender);
+
+  // ui::ClientNativePixmapFactory:
+  std::vector<Configuration> GetSupportedConfigurations() const override;
+  scoped_ptr<ui::ClientNativePixmap> ImportNativePixmap(
+      const base::FileDescriptor& handle,
+      const gfx::Size& size,
+      gfx::BufferFormat format,
+      gfx::BufferUsage usage) override;
+
+ private:
+  friend struct BrowserClientNativePixmapFactoryTrait;
+  BrowserClientNativePixmapFactory();
+
+  void Initialize(const base::FileDescriptor& virtual_device) override;
+
+  scoped_ptr<ui::ClientNativePixmapFactory> pixmap_factory_;
+  base::FileDescriptor virtual_device_;
+
+  DISALLOW_COPY_AND_ASSIGN(BrowserClientNativePixmapFactory);
+};
+
+}  // namespace content
+
+#endif  // CONTENT_BROWSER_GPU_BROWSER_CLIENT_NATIVE_PIXMAP_FACTORY_OZONE_H_