ozone: ClientPixmapManager passes VGEM fd from browser to renderer.

content/browser/renderer_host/render_process_host_impl.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Represents the browser side of the browser <--> renderer communication
 // channel. There will be one RenderProcessHost per renderer process.
 
 #include "content/browser/renderer_host/render_process_host_impl.h"
 
 #include <algorithm>
@@ skipping 173 matching lines @@
 #include "content/common/sandbox_win.h"
 #include "sandbox/win/src/sandbox_policy.h"
 #include "ui/gfx/win/dpi.h"
 #endif
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
 #include "content/browser/browser_io_surface_manager_mac.h"
 #endif
 
 #if defined(USE_OZONE)
+#include "ui/ozone/public/client_native_pixmap_factory.h"
 #include "ui/ozone/public/ozone_switches.h"
 #endif
 
 #if defined(ENABLE_BROWSER_CDMS)
 #include "content/browser/media/cdm/browser_cdm_manager.h"
 #endif
 
 #if defined(ENABLE_PLUGINS)
 #include "content/browser/plugin_service_impl.h"
 #endif
@@ skipping 1390 matching lines @@
   tracked_objects::ThreadData::Status status =
       tracked_objects::ThreadData::status();
   Send(new ChildProcessMsg_SetProfilerStatus(status));
 
 #if defined(OS_MACOSX) && !defined(OS_IOS)
   io_surface_manager_token_ =
       BrowserIOSurfaceManager::GetInstance()->GenerateChildProcessToken(
           GetID());
   Send(new ChildProcessMsg_SetIOSurfaceManagerToken(io_surface_manager_token_));
 #endif
+#if defined(USE_OZONE)
+  int vgem_fd = ui::ClientNativePixmapFactory::GetInstance()->OpenVgemFD();

[reveman, 2015/08/14 13:19:12]

It's seems wrong that we ask the client factory to open a vgem fd. Should this
not be part of a more privileged API or at least be made a static function and
not part of the client side interface?

[dshwang, 2015/08/14 16:20:27]

spang, what do you think?
I chose ClientNativePixmapFactory because I wanted privileged API (i.e.
OzonePlatform) to be not aware of VGEM.
static function is not good because Ozone platform is chosen in run time. If I
implement it in static function, all Ozone platforms will know the API, which
mean all Ozone platforms become aware of "/dev/dri/renderD129".

As we encounter repeatedly, we need to make decision how much other Ozone
platforms are aware of vgem. In previous patch set, I made other platforms
consider it as "virtual_device".

+  Send(new ChildProcessMsg_SetVgemFD(base::FileDescriptor(vgem_fd, true)));
+#endif
 }
 
 void RenderProcessHostImpl::OnChannelError() {
   ProcessDied(true /* already_dead */, nullptr);
 }
 
 void RenderProcessHostImpl::OnBadMessageReceived(const IPC::Message& message) {
   // Message de-serialization failed. We consider this a capital crime. Kill the
   // renderer if we have one.
   LOG(ERROR) << "bad message " << message.type() << " terminating renderer.";
@@ skipping 914 matching lines @@
 void RenderProcessHostImpl::GetAudioOutputControllers(
     const GetAudioOutputControllersCallback& callback) const {
   audio_renderer_host()->GetOutputControllers(callback);
 }
 
 BluetoothDispatcherHost* RenderProcessHostImpl::GetBluetoothDispatcherHost() {
   return bluetooth_dispatcher_host_.get();
 }
 
 }  // namespace content