make color emoji gm portable

make color emoji gm portable

R=bungeman@google.com

Committed: https://skia.googlesource.com/skia/+/c3dcb67f07173af1c17771965ab7254910d52ef3

[caryclark, 2015-07-21 17:54:06]

The CQ bit was checked by caryclark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-07-21 17:54:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1248703004/1

[commit-bot: I haz the power, 2015-07-21 18:02:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-21 18:02:23]

Dry run: This issue passed the CQ dry run.

[bungeman-skia, 2015-07-21 18:17:16]

https://codereview.chromium.org/1248703004/diff/1/gm/dftext.cpp
File gm/dftext.cpp (right):

https://codereview.chromium.org/1248703004/diff/1/gm/dftext.cpp#newcode86
gm/dftext.cpp:86: const char* text = "Hamburgefons";
Apple Color Emoji should use different chars here to get something colorful.
Maybe we want a means of obtaining a color font and some text to go with it. We
already need three copies of that logic.

[caryclark, 2015-07-21 18:42:43]

On 2015/07/21 18:17:16, bungeman1 wrote:
> https://codereview.chromium.org/1248703004/diff/1/gm/dftext.cpp
> File gm/dftext.cpp (right):
> 
> https://codereview.chromium.org/1248703004/diff/1/gm/dftext.cpp#newcode86
> gm/dftext.cpp:86: const char* text = "Hamburgefons";
> Apple Color Emoji should use different chars here to get something colorful.
> Maybe we want a means of obtaining a color font and some text to go with it.
We
> already need three copies of that logic.

Fixed. All three tests should use common logic and content now.

[bungeman-skia, 2015-07-21 18:47:07]

lgtm

[caryclark, 2015-07-21 19:04:00]

The CQ bit was checked by caryclark@google.com

[caryclark, 2015-07-21 19:04:01]

The patchset sent to the CQ was uploaded after l-g-t-m from bungeman@google.com
Link to the patchset: https://codereview.chromium.org/1248703004/#ps60001
(title: "more 565 color fixes")

[commit-bot: I haz the power, 2015-07-21 19:04:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1248703004/60001

[commit-bot: I haz the power, 2015-07-21 19:27:39]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/c3dcb67f07173af1c17771965ab7254910d52ef3