Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8020)

Unified Diff: content/renderer/webplugin_delegate_proxy.cc

Issue 12487003: Fix painting glitch with text and NPAPI plugins. This was a regression from r167042. The problem wa… (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix silverlight Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/webplugin_delegate_proxy.h ('k') | webkit/plugins/npapi/plugin_instance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/webplugin_delegate_proxy.cc
===================================================================
--- content/renderer/webplugin_delegate_proxy.cc (revision 186240)
+++ content/renderer/webplugin_delegate_proxy.cc (working copy)
@@ -214,6 +214,7 @@
npobject_(NULL),
sad_plugin_(NULL),
invalidate_pending_(false),
+ transparent_(false),
front_buffer_index_(0),
page_url_(render_view_->webview()->mainFrame()->document().url()) {
}
@@ -373,7 +374,7 @@
plugin_ = plugin;
result = false;
- Send(new PluginMsg_Init(instance_id_, params, &result));
+ Send(new PluginMsg_Init(instance_id_, params, &transparent_, &result));
if (!result)
LOG(ERROR) << "PluginMsg_Init returned false";
@@ -725,7 +726,8 @@
const SkBitmap& bitmap =
front_buffer_canvas()->getDevice()->accessBitmap(false);
SkPaint paint;
- paint.setXfermodeMode(SkXfermode::kSrcATop_Mode);
+ paint.setXfermodeMode(
+ transparent_ ? SkXfermode::kSrcATop_Mode : SkXfermode::kSrc_Mode);
SkIRect src_rect = gfx::RectToSkIRect(offset_rect);
canvas->drawBitmapRect(bitmap,
&src_rect,
« no previous file with comments | « content/renderer/webplugin_delegate_proxy.h ('k') | webkit/plugins/npapi/plugin_instance.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698