Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4991)

Unified Diff: net/quic/quic_packet_generator_test.cc

Issue 1248683002: Revert of relnote: Protect against a QUIC crash bug but logging a DFATAL and (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_packet_generator.cc ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_packet_generator_test.cc
diff --git a/net/quic/quic_packet_generator_test.cc b/net/quic/quic_packet_generator_test.cc
index bd6a207715e463634e0f4823274db4a7c0253153..6cbacb46d7449a2989c46a00853d75320eed9d53 100644
--- a/net/quic/quic_packet_generator_test.cc
+++ b/net/quic/quic_packet_generator_test.cc
@@ -1626,32 +1626,5 @@
CheckPacketHasSingleStreamFrame(4);
}
-TEST_P(QuicPacketGeneratorTest, DontCrashOnInvalidStopWaiting) {
- // Test added to ensure the generator does not crash when an invalid frame is
- // added. Because this is an indication of internal programming errors,
- // DFATALs are expected.
- // A 1 byte sequence number length can't encode a gap of 1000.
- QuicPacketCreatorPeer::SetSequenceNumber(creator_, 1000);
-
- delegate_.SetCanNotWrite();
- generator_.SetShouldSendAck(true);
- delegate_.SetCanWriteAnything();
- generator_.StartBatchOperations();
-
- // Set up frames to write into the creator when control frames are written.
- EXPECT_CALL(delegate_, PopulateAckFrame(_));
- EXPECT_CALL(delegate_, PopulateStopWaitingFrame(_));
- // Generator should have queued control frames, and creator should be empty.
- EXPECT_TRUE(generator_.HasQueuedFrames());
- EXPECT_FALSE(creator_->HasPendingFrames());
-
- // This will not serialize any packets, because of the invalid frame.
- EXPECT_CALL(delegate_,
- CloseConnection(QUIC_FAILED_TO_SERIALIZE_PACKET, false));
- EXPECT_DFATAL(generator_.FinishBatchOperations(),
- "sequence_number_length 1 is too small "
- "for least_unacked_delta: 1001");
-}
-
} // namespace test
} // namespace net
« no previous file with comments | « net/quic/quic_packet_generator.cc ('k') | net/quic/quic_protocol.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698