Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(558)

Issue 1248683002: Revert of relnote: Protect against a QUIC crash bug but logging a DFATAL and (Closed)

Created:
5 years, 5 months ago by jonross
Modified:
5 years, 5 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of relnote: Protect against a QUIC crash bug but logging a DFATAL and (patchset #1 id:1 of https://codereview.chromium.org/1246793002/) Reason for revert: The test added in this patch is crashing on Chrome OS. See crbug.com/512417 Original issue's description: > relnote: Protect against a QUIC crash bug but logging a DFATAL and > closing the connection instead when a packet cannot be serialized. > > This could help fixing Chromium BUG=479880 . > > Merge internal change: 98506577 > > R=rch@chromium.org > > Committed: https://crrev.com/0a2dccc01366309f1e55a9b86141137bb649c631 > Cr-Commit-Position: refs/heads/master@{#339532} TBR=rch@chromium.org,rtenneti@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5b1ea4388e2378f0af0ff5ff5631f47517166a9f Cr-Commit-Position: refs/heads/master@{#339645}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -42 lines) Patch
M net/quic/quic_packet_creator.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M net/quic/quic_packet_generator.cc View 1 chunk +1 line, -6 lines 0 comments Download
M net/quic/quic_packet_generator_test.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M net/quic/quic_protocol.h View 2 chunks +1 line, -3 lines 0 comments Download
M net/quic/quic_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jonross
Created Revert of relnote: Protect against a QUIC crash bug but logging a DFATAL and
5 years, 5 months ago (2015-07-21 13:52:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248683002/1
5 years, 5 months ago (2015-07-21 13:52:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 13:53:29 UTC) #3
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 13:54:35 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b1ea4388e2378f0af0ff5ff5631f47517166a9f
Cr-Commit-Position: refs/heads/master@{#339645}

Powered by Google App Engine
This is Rietveld 408576698