Test distillability without JavaScript

components/dom_distiller/content/browser/distillable_page_utils.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/dom_distiller/content/browser/distillable_page_utils.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/single_thread_task_runner.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/thread_task_runner_handle.h"
 #include "base/values.h"
+#include "components/dom_distiller/content/browser/distillability_driver.h"
 #include "components/dom_distiller/content/browser/distiller_javascript_utils.h"
+#include "components/dom_distiller/content/common/distiller_messages.h"
 #include "components/dom_distiller/core/distillable_page_detector.h"
 #include "components/dom_distiller/core/experiments.h"
 #include "components/dom_distiller/core/page_features.h"
 #include "content/public/browser/render_frame_host.h"
 #include "grit/components_resources.h"
 #include "ui/base/resource/resource_bundle.h"
 
 namespace dom_distiller {
 namespace {
+
 void OnOGArticleJsResult(base::Callback<void(bool)> callback,
                          const base::Value* result) {
   bool success = false;
   if (result) {
     result->GetAsBoolean(&success);
   }
   callback.Run(success);
 }
 
+#if defined(OS_IOS)

[mdjones, 2015/09/29 17:31:42]

I don't think we need this for code in the dom_distiller/content directory since
content is not used in iOS.

It would be nice to have this logic somewhere in core that can be overridden
somehow. I think that would be a separate change though since I don't believe
the detector runs on iOS.

[wychen, 2015/09/29 21:46:57]

Done.

 void OnExtractFeaturesJsResult(const DistillablePageDetector* detector,
                                base::Callback<void(bool)> callback,
                                const base::Value* result) {
   callback.Run(detector->Classify(CalculateDerivedFeaturesFromJSON(result)));
 }
+#else // defined(OS_IOS)
+void OnExtractFeaturesNativeResult(
+    const DistillablePageDetector* detector,
+    base::Callback<void(bool)> callback,
+    bool isOGArticle,
+    const std::string& url,
+    int numElements,
+    int numAnchors,
+    int numForms,
+    const std::string& innerText,
+    const std::string& textContent,
+    const std::string& innerHTML) {
+
+  GURL parsed_url(url);
+  if (!parsed_url.is_valid()) {
+    callback.Run(false);
+    return;
+  }
+
+  auto res = CalculateDerivedFeatures(
+      isOGArticle,
+      parsed_url,
+      numElements,
+      numAnchors,
+      numForms,
+      innerText,
+      textContent,
+      innerHTML
+  );
+  callback.Run(detector->Classify(res));
+}
+#endif // defined(OS_IOS)
+
 }  // namespace
 
 void IsOpenGraphArticle(content::WebContents* web_contents,
                         base::Callback<void(bool)> callback) {
   content::RenderFrameHost* main_frame = web_contents->GetMainFrame();
   if (!main_frame) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
                                                   base::Bind(callback, false));
     return;
   }
@@ skipping 35 matching lines @@
 
 void IsDistillablePageForDetector(content::WebContents* web_contents,
                                   const DistillablePageDetector* detector,
                                   base::Callback<void(bool)> callback) {
   content::RenderFrameHost* main_frame = web_contents->GetMainFrame();
   if (!main_frame) {
     base::ThreadTaskRunnerHandle::Get()->PostTask(FROM_HERE,
                                                   base::Bind(callback, false));
     return;
   }
+
+#if defined(OS_IOS)

[mdjones, 2015/09/29 17:31:42]

Same as above (not needed for content).

[wychen, 2015/09/29 21:46:57]

Done.

   std::string extract_features_js =
       ResourceBundle::GetSharedInstance()
           .GetRawDataResource(IDR_EXTRACT_PAGE_FEATURES_JS)
           .as_string();
   RunIsolatedJavaScript(
       main_frame, extract_features_js,
       base::Bind(OnExtractFeaturesJsResult, detector, callback));
+#else
+  WebContentsDistillabilityDriver::CreateForWebContents(web_contents);
+  WebContentsDistillabilityDriver *driver =
+      WebContentsDistillabilityDriver::FromWebContents(web_contents);
+  CHECK(driver);
+  driver->ExtractFeatures(
+      base::Bind(OnExtractFeaturesNativeResult, detector, callback));
+#endif
 }
 
 }  // namespace dom_distiller