Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: pkg/analyzer/lib/src/services/formatter_impl.dart

Issue 124863004: Formatter fixes (symbols, natives, function type aliases, oh my). (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/cu_tests.data » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/services/formatter_impl.dart
===================================================================
--- pkg/analyzer/lib/src/services/formatter_impl.dart (revision 31502)
+++ pkg/analyzer/lib/src/services/formatter_impl.dart (working copy)
@@ -506,6 +506,7 @@
visitNode(node.extendsClause, precededBy: space);
visitNode(node.withClause, precededBy: space);
visitNode(node.implementsClause, precededBy: space);
+ visitNode(node.nativeClause, precededBy: space);
space();
});
token(node.leftBracket);
@@ -825,7 +826,10 @@
//TODO(pquitslund): remove this workaround once setter functions
//have their return types properly set (dartbug.com/15914)
if (node.returnType == null && node.propertyKeyword != null) {
- modifier(node.propertyKeyword.previous);
+ var previous = node.propertyKeyword.previous;
+ if (previous is KeywordToken && previous.keyword == Keyword.VOID) {
+ modifier(previous);
+ }
} else {
visitNode(node.returnType, followedBy: space);
}
@@ -852,6 +856,7 @@
}
visitFunctionTypeAlias(FunctionTypeAlias node) {
+ visitNodes(node.metadata, separatedBy: newlines, followedBy: newlines);
token(node.keyword);
space();
visitNode(node.returnType, followedBy: space);
@@ -1205,7 +1210,16 @@
}
visitSymbolLiteral(SymbolLiteral node) {
- // No-op ?
+ token(node.poundSign);
+ var components = node.components;
+ var size = components.length;
+ for (var component in components) {
+ // The '.' separator
+ if (component.previous.lexeme == '.') {
+ token(component.previous);
+ }
+ token(component);
+ }
}
visitThisExpression(ThisExpression node) {
« no previous file with comments | « no previous file | pkg/analyzer/test/services/data/cu_tests.data » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698