Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
124863002:
Fix build on OSX. (Closed)
|
Created:
6 years, 11 months ago by pwnall-personal Modified:
6 years, 11 months ago CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionFix broken build on OSX >= 10.7.
The breakage appears to be introduced by this CL.
https://codereview.chromium.org/120773007
TEST=ninja -C out/Debug blink_tests
BUG=331719
NOTRY=true
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243091
Patch Set 1 #
Total comments: 1
Messages
Total messages: 9 (0 generated)
I got this error before.
[17/2771] OBJCXX
obj/content/shell/renderer/test_runner/helper/layout_test_helper.layout_test_helper_mac.o
FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/content/shell/renderer/test_runner/helper/layout_test_helper.layout_test_helper_mac.o.d
-DV8_DEPRECATION_WARNINGS -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1
-DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1
-DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH
-DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1
-DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY
-DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE
-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DENABLE_EGLIMAGE=1
-DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1
-DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1
-DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1
-DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1
-DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1
-DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1
-DWTF_USE_DYNAMIC_ANNOTATIONS=1 -isysroot
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk
-O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof
-mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra
-Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene
-Wno-c++11-narrowing -Wno-char-subscripts -Wno-unneeded-internal-declaration
-Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register
-std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden
-fno-threadsafe-statics -Xclang -load -Xclang
/Users/pwnall/chromium/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics
-fno-strict-aliasing -fstack-protector-all -Wobjc-missing-property-synthesis
-fobjc-call-cxx-cdtors -c
../../content/shell/renderer/test_runner/helper/layout_test_helper_mac.mm -o
obj/content/shell/renderer/test_runner/helper/layout_test_helper.layout_test_helper_mac.o
../../content/shell/renderer/test_runner/helper/layout_test_helper_mac.mm:60:40:
error: use of undeclared identifier 'CGmain_display_id'
CGDisplayCreateUUIDFromDisplayID(CGmain_display_id());
^
I assumed it's a typo, and put together this fix. What do you think?
On 2014/01/06 02:55:23, pwnall wrote: > I got this error before. > > [17/2771] OBJCXX > obj/content/shell/renderer/test_runner/helper/layout_test_helper.layout_test_helper_mac.o > FAILED: ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF > obj/content/shell/renderer/test_runner/helper/layout_test_helper.layout_test_helper_mac.o.d > -DV8_DEPRECATION_WARNINGS -DCHROMIUM_BUILD -DUSE_LIBJPEG_TURBO=1 > -DENABLE_ONE_CLICK_SIGNIN -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 > -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH > -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 > -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY > -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE > -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC -DENABLE_EGLIMAGE=1 > -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 > -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 > -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_AUTOMATION=1 > -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 > -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 > -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 > -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 > -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -isysroot > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.8.sdk > -O0 -gdwarf-2 -fvisibility=hidden -Werror -Wnewline-eof > -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra > -Wno-unused-parameter -Wno-missing-field-initializers -Wheader-hygiene > -Wno-c++11-narrowing -Wno-char-subscripts -Wno-unneeded-internal-declaration > -Wno-covered-switch-default -Wstring-conversion -Wno-deprecated-register > -std=gnu++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden > -fno-threadsafe-statics -Xclang -load -Xclang > /Users/pwnall/chromium/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib > -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics > -fno-strict-aliasing -fstack-protector-all -Wobjc-missing-property-synthesis > -fobjc-call-cxx-cdtors -c > ../../content/shell/renderer/test_runner/helper/layout_test_helper_mac.mm -o > obj/content/shell/renderer/test_runner/helper/layout_test_helper.layout_test_helper_mac.o > ../../content/shell/renderer/test_runner/helper/layout_test_helper_mac.mm:60:40: > error: use of undeclared identifier 'CGmain_display_id' > CGDisplayCreateUUIDFromDisplayID(CGmain_display_id()); > ^ > > I assumed it's a typo, and put together this fix. What do you think? Based on what I read on the mailing lists, I think the trybots are running 10.6. This would explain why the error got through.
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an LGTM may have been provided, it was from a non-committer or a lowly provisional committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/124863002/1
lgtm https://codereview.chromium.org/124863002/diff/1/content/shell/renderer/test_... File content/shell/renderer/test_runner/helper/layout_test_helper_mac.mm (right): https://codereview.chromium.org/124863002/diff/1/content/shell/renderer/test_... content/shell/renderer/test_runner/helper/layout_test_helper_mac.mm:60: CGDisplayCreateUUIDFromDisplayID(CGMainDisplayID()); ops, looks like I missed on spot :( Thanks for fixing this! That is what happens when you do: %s/mainDisplayID/main_display_id/g careless :)
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/costan@gmail.com/124863002/1
Message was sent while issue was closed.
Change committed as 243091 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||
