Issue 501916 : Add data type counts to profile deletion flow

chrome/browser/profiles/profile_statistics.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PROFILES_PROFILE_STATISTICS_H_
+#define CHROME_BROWSER_PROFILES_PROFILE_STATISTICS_H_
+
+#include <string>
+#include <utility>
+#include <vector>
+#include "base/task/cancelable_task_tracker.h"
+#include "chrome/browser/profiles/profile.h"
+
+namespace profiles {

[msramek, 2015/07/29 18:10:25]

Nit: Empty line after this line.

[lwchkg, 2015/07/30 17:07:19]

Acknowledged.

+// Definition of the return value of |ProfileStatisticsCallback|.
+// The data stored in |ProfileStatisticsValues| looks like this:
+// <"Browsing History", 912>, <"Passwords", 71>, <"Bookmarks", 120>,
+// <"Settings", 200>
+typedef std::vector<std::pair<std::string, int> > ProfileStatisticsValues;

[msramek, 2015/07/29 18:10:25]

Wouldn't std::map<std::string, int> be preferable?

And actually, it's not ideal to key these items by strings. If this goes
directly to the UI and only there, then I understand that it's convenient. But
it's not really reusable, because all callsites must know the strings to extract
the data they need.

[lwchkg, 2015/07/30 17:07:19]

I agree, but that vector is the idea of Mike, so I'd also ask for his opinion.
Anyway, the result is simply converted to a DictionaryValue (i.e. a Map) before
transferring to JavaScript.

(See comments #7, #9, #11 in issue 501916.)
Not sure about this. Currently all existing and potential callsites are from
JavaScript, but I don't know whether it will be processed by C++ code in the
future.

+// Definition of the callback function. Note that a copy of
+// |ProfileStatisticsValues| is made each time the callback is called.
+typedef base::Callback<void(ProfileStatisticsValues)>
+    ProfileStatisticsCallback;
+
+// This class collect statistical information about the profile and returns the

[msramek, 2015/07/29 18:10:25]

Copy-pasted comment. Please update.

[lwchkg, 2015/07/30 17:07:19]

Acknowledged.

+// information via a callback function. Currently bookmarks, history, logins and
+// preferences are counted. The callback function may be called more than once.
+void GetProfileStatistics(Profile* profile,

[msramek, 2015/07/29 18:10:25]

Nit: formatting.

http://google-styleguide.googlecode.com/svn/trunk/cppguide.html#Function_Calls

[lwchkg, 2015/07/30 17:07:19]

Acknowledged.

+    const ProfileStatisticsCallback& callback,
+    base::CancelableTaskTracker* tracker);
+
+}  // namespace profiles
+
+#endif  // CHROME_BROWSER_PROFILES_PROFILE_STATISTICS_H_