chrome/app/generated_resources.grd

Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index d29f61a8be7a0bb36118124fc6a3703d6eb26343..34ba7d59d384e2cd3298587617850ad76ad93aa3 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -14079,8 +14079,46 @@ After you create a new supervised user, you can manage their settings at any tim
           All files and local data associated with the supervised user will be permanently deleted once this supervised user is removed. Visited websites and settings for this supervised user may still be visible by the manager at <ph name="MANAGEMENT_URL">$1<ex>www.example.com</ex></ph>.
         </message>
         <if expr="not chromeos">
-          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING" desc="Text shown as a warning when attempting to remove an user.">
-            Are you sure you want to delete this user and all the data associated with it from this computer? This cannot be undone!
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_NONSYNC" desc="Main text shown as a warning when attempting to remove an user.">
+            {NUM_ITEMS, plural,
+            =1 {This will permanently delete $1 item from this device.}

[msramek, 2015/09/15 15:33:09]

$1, $2, etc. are used when you're substituting value for placeholders in a
regular string

In these plural constructions, the placeholder for the number in question is
represented by "#".

(search for other plural strings in this file to see an example)

[lwchkg, 2015/09/15 19:06:28]

The $1 is substituted in my JS code with the number put inside a <span> tag. I
admit that this is ugly. I've previously tried to put the HTML tag here and set
innerHTML in the JS code, but Dmitry has opposed the idea in
https://codereview.chromium.org/1248613003/diff/220001/ui/login/account_picke....

Anyway, see the attached picture in the description of bug 501916 for an idea
why an HTML tag is needed.

+            other {This will permanently delete $1 items from this device.}}
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_NONSYNC_WITH_ERRORS" desc="Main text shown as a warning when attempting to remove an user (with some statistics failed to load).">

[msramek, 2015/09/15 15:33:08]

nit: s/with/when ?

[lwchkg, 2015/09/15 19:06:28]

Acknowledged and thanks.

+            {NUM_ITEMS, plural,
+            =1 {This will permanently delete at least $1 item from this device.}
+            other {This will permanently delete at least $1 items from this device.}}
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_NONSYNC_NOSTATS" desc="Main text shown as a warning when attempting to remove an user.">

[msramek, 2015/09/15 15:33:08]

Please change the description to explain what is the difference from
IDS_LOGIN_POD_USER_REMOVE_WARNING_NONSYNC.

[lwchkg, 2015/09/15 19:06:28]

Acknowledged.

+            This will permanently delete your browsing data from this device.
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_HISTORY" desc="One of the statistics shown below the warning when attempting to remove an user. This is the category, and a number is displayed next to it.">

[msramek, 2015/09/15 15:33:08]

Please customize the string descriptions: "Title of the statistic ... for
browsing history ..."

[lwchkg, 2015/09/15 19:06:28]

Acknowledged.

+            Browsing History
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_PASSWORDS" desc="One of the statistics shown below the warning when attempting to remove an user. This is the category, and a number is displayed next to it.">
+            Passwords
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_BOOKMARKS" desc="One of the statistics shown below the warning when attempting to remove an user. This is the category, and a number is displayed next to it.">
+            Bookmarks
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_SETTINGS" desc="One of the statistics shown below the warning when attempting to remove an user. This is the category, and a number is displayed next to it.">
+            Settings
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_CALCULATING" desc="This is used in '...' of the warning message 'This will permanently delete ... items from the device.', which is shown when attempting to remove an user. Also put next to any loading statistics below this warning. All occurences of '...' will be eventually replaced by numbers when the statistics are loaded.">

[msramek, 2015/09/15 15:33:08]

As you noted yourself on the bug, it's probably better to have this sentence
translated separately.

One of the reasons is that the plural strings work with the number itself (#
parameter), they won't accept any string for substitution (you can't do $1 =
'...').

[lwchkg, 2015/09/15 19:06:28]

# is not okay, but $1 is possible with my own JS code. But I'll in for a
separate string because this is less error-prone.

+            ...
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_SYNC" desc="Main text shown as a warning when attempting to remove an user with a synced account.">
+            {NUM_ITEMS, plural,
+            =1 {This will permanently delete $1 item from this device but will not clear synced items from other devices.}
+            other {This will permanently delete $1 items from this device but will not clear synced items from other devices.}}
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_SYNC_WITH_ERRORS" desc="Main text shown as a warning when attempting to remove an user with a synced account (with some statistics failed to load).">
+            {NUM_ITEMS, plural,
+            =1 {This will permanently delete at least $1 item from this device but will not clear synced items from other devices.}
+            other {This will permanently delete at least $1 items from this device but will not clear synced items from other devices.}}
+          </message>
+          <message name="IDS_LOGIN_POD_USER_REMOVE_WARNING_SYNC_NOSTATS" desc="Main text shown as a warning when attempting to remove an user with a synced account having statistics unavailable.">
+            This will permanently delete your browsing data from this device but will not clear synced items from other devices.
           </message>
         </if>