Issue 501916 : Add data type counts to profile deletion flow

components/history/core/browser/visit_database.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/history/core/browser/visit_database.h"
 
 #include <algorithm>
 #include <limits>
 #include <map>
 #include <set>
@@ skipping 518 matching lines @@
   }
 
   if (!statement.Succeeded())
     return false;
 
   *first_visit = base::Time::FromInternalValue(statement.ColumnInt64(0));
   *count = statement.ColumnInt(1);
   return true;
 }
 
+int VisitDatabase::GetCountOfURLsWithVisibleVisit() {

[lwchkg, 2015/08/11 15:54:51]

Please discuss the naming of this function. It should count in the same way in
chrome://history/ , with dates set to infinity.

I'd suggest GetHistoryCount because it is difficult to write down the URL-days
concept in the function name. I'll update the function names and related
comments once the names are decided.

Mike and James: is the above proposed name okay? If not please suggest some
other names.

[lwchkg, 2015/08/12 17:47:30]

@sdefrense and @sky: Please check the code here. Thanks.

[Mike Lerman, 2015/08/13 14:56:33]

I think GetCountHistoryEntries extends well to this function?

+  sql::Statement statement(GetDB().GetCachedStatement(SQL_FROM_HERE,
+      "SELECT COUNT(*) FROM ("
+      "SELECT DISTINCT url, "
+      // Convert unit of timestamp from the numbers of microseconds since
+      // Windows Epoch to the number of seconds from Unix Epoch.
+      "DATE(visit_time/1000000-11644473600, 'localtime', 'unixepoch') "
+      "FROM visits "
+      "WHERE (transition & ?) != 0 "  // CHAIN_END
+      "AND (transition & ?) NOT IN (?, ?, ?)"  // NO SUBFRAME or
+                                               // KEYWORD_GENERATED
+      ")"));
+
+  statement.BindInt(0, ui::PAGE_TRANSITION_CHAIN_END);
+  statement.BindInt(1, ui::PAGE_TRANSITION_CORE_MASK);
+  statement.BindInt(2, ui::PAGE_TRANSITION_AUTO_SUBFRAME);
+  statement.BindInt(3, ui::PAGE_TRANSITION_MANUAL_SUBFRAME);
+  statement.BindInt(4, ui::PAGE_TRANSITION_KEYWORD_GENERATED);
+
+  statement.Step();
+  return statement.ColumnInt(0);
+}
+
 bool VisitDatabase::GetStartDate(base::Time* first_visit) {
   sql::Statement statement(GetDB().GetCachedStatement(SQL_FROM_HERE,
       "SELECT MIN(visit_time) FROM visits WHERE visit_time != 0"));
   if (!statement.Step() || statement.ColumnInt64(0) == 0) {
     *first_visit = base::Time::Now();
     return false;
   }
   *first_visit = base::Time::FromInternalValue(statement.ColumnInt64(0));
   return true;
 }
@@ skipping 44 matching lines @@
     // Old versions don't have the visit_duration column, we modify the table
     // to add that field.
     if (!GetDB().Execute("ALTER TABLE visits "
         "ADD COLUMN visit_duration INTEGER DEFAULT 0 NOT NULL"))
       return false;
   }
   return true;
 }
 
 }  // namespace history