Issue 501916 : Add data type counts to profile deletion flow

chrome/browser/profiles/profile_statistics.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/profiles/profile_statistics.h"
+
+#include "base/bind.h"
+#include "base/memory/ref_counted.h"
+#include "base/prefs/pref_service.h"
+#include "base/task_runner.h"
+#include "chrome/browser/bookmarks/bookmark_model_factory.h"
+#include "chrome/browser/history/history_service_factory.h"
+#include "chrome/browser/password_manager/password_store_factory.h"
+#include "components/bookmarks/browser/bookmark_model.h"
+#include "components/history/core/browser/history_service.h"
+#include "components/password_manager/core/browser/password_store.h"
+#include "components/password_manager/core/browser/password_store_consumer.h"
+#include "content/public/browser/browser_thread.h"
+
+using content::BrowserThread;
+
+namespace profiles {
+
+// Constants for the categories in ProfileStatisticsValues
+const char kProfileStatisticsBrowsingHistory[] = "BrowsingHistory";
+const char kProfileStatisticsPasswords[] = "Passwords";
+const char kProfileStatisticsBookmarks[] = "Bookmarks";
+const char kProfileStatisticsSettings[] = "Settings";
+
+class ProfileStatisticsAggregator

[lwchkg, 2015/08/07 10:43:48]

Should I move the class into to anonymous namespace?

[Mike Lerman, 2015/08/07 19:37:12]

Yes please. Anything not publicly exposed in the header file should be defined
here in the anonymous namespace.

[lwchkg, 2015/08/09 16:11:49]

Acknowledged.

+    : public base::RefCountedThreadSafe<ProfileStatisticsAggregator> {
+  // This class collect statistical information about the profile and returns

[Mike Lerman, 2015/08/07 19:37:12]

nit: collect needs an s

[lwchkg, 2015/08/09 16:11:49]

Acknowledged.

+  // the information via a callback function. Currently bookmarks, history,
+  // logins and preferences are counted.
+  //
+  // The class is RefCounted because this is needed for CancelableTaskTracker
+  // to function properly. Once all tasks are run (or cancelled) the instance is
+  // automatically destructed.
+  //
+  // The class is used internally by GetProfileStatistics function.
+
+ public:
+  // Constructor
+  explicit ProfileStatisticsAggregator(Profile* profile,
+      const ProfileStatisticsCallback& callback,
+      base::CancelableTaskTracker* tracker);
+
+ private:
+  // Destructor
+  friend class base::RefCountedThreadSafe<ProfileStatisticsAggregator>;
+  ~ProfileStatisticsAggregator() {}
+
+  // Private variables

[Mike Lerman, 2015/08/07 19:37:12]

nit: don't need to specify private variables in a comment

[lwchkg, 2015/08/09 16:11:49]

Acknowledged.

+  Profile* profile_;
+  ProfileStatisticsValues profile_stats_values_;
+
+  // Callback function to be called when results arrive. Will be called
+  // multiple times (once for each statistics).
+  const ProfileStatisticsCallback callback_;
+
+  base::CancelableTaskTracker* tracker_;
+
+  // Initialization. Called by constructors.
+  void Init();
+
+  // Internal callback. Appends result to profile_stats_values_, and then
+  // call the external callback.
+  void StatisticsCallback(std::string category, int count);
+
+  // Bookmark counting.
+  static int CountBookmarksFromNode(const bookmarks::BookmarkNode* node);
+  int CountBookmarks() const;
+
+  // Preference counting.
+  int CountPrefs() const;
+
+  // Password counting
+  class PasswordStoreConsumerHelper
+      : public password_manager::PasswordStoreConsumer {
+   public:
+    explicit PasswordStoreConsumerHelper(ProfileStatisticsAggregator* parent)
+        : parent_(parent) {}
+
+    void OnGetPasswordStoreResults(
+        ScopedVector<autofill::PasswordForm> results) override {
+      parent_->StatisticsCallback(kProfileStatisticsPasswords, results.size());
+    }
+
+   private:
+    ProfileStatisticsAggregator* parent_;
+
+    DISALLOW_COPY_AND_ASSIGN(PasswordStoreConsumerHelper);
+  };
+  PasswordStoreConsumerHelper password_store_consumer_helper_;
+
+  DISALLOW_COPY_AND_ASSIGN(ProfileStatisticsAggregator);
+};
+
+ProfileStatisticsAggregator::ProfileStatisticsAggregator(Profile* profile,
+    const ProfileStatisticsCallback& callback,
+    base::CancelableTaskTracker* tracker)
+    : profile_(profile),
+      callback_(callback),
+      tracker_(tracker),
+      password_store_consumer_helper_(this) {
+  Init();
+}
+
+void ProfileStatisticsAggregator::Init() {
+  // Initiate bookmark counting (async). Post to UI thread.
+  tracker_->PostTaskAndReplyWithResult(
+      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI).get(),
+          FROM_HERE,
+          base::Bind(&ProfileStatisticsAggregator::CountBookmarks, this),
+          base::Bind(&ProfileStatisticsAggregator::StatisticsCallback,
+                     this, kProfileStatisticsBookmarks));
+
+  // Initiate history counting (async).
+  history::HistoryService* history_service =
+      HistoryServiceFactory::GetForProfileWithoutCreating(profile_);
+
+  if (history_service) {
+    history_service->CountURLs(
+        base::Bind(&ProfileStatisticsAggregator::StatisticsCallback,
+                   this, kProfileStatisticsBrowsingHistory),
+        tracker_);
+  } else {
+    StatisticsCallback(kProfileStatisticsBrowsingHistory, 0);

[lwchkg, 2015/08/07 10:43:48]

Still waiting for reply here. Let's reach a decision before changes is made.

+  }
+
+  // Initiate stored password counting (async).
+  // TODO(anthonyvd): make password task cancellable.
+  scoped_refptr<password_manager::PasswordStore> password_store =
+      PasswordStoreFactory::GetForProfile(
+          profile_, ServiceAccessType::EXPLICIT_ACCESS);
+  password_store->GetAutofillableLogins(&password_store_consumer_helper_);
+
+  // Initiate preference counting (async). Post to UI thread.
+  tracker_->PostTaskAndReplyWithResult(
+      BrowserThread::GetMessageLoopProxyForThread(BrowserThread::UI).get(),
+          FROM_HERE,
+          base::Bind(&ProfileStatisticsAggregator::CountPrefs, this),
+          base::Bind(&ProfileStatisticsAggregator::StatisticsCallback,
+                     this, kProfileStatisticsSettings));
+}
+
+void ProfileStatisticsAggregator::StatisticsCallback(std::string category,
+                                                  int count) {

[Mike Lerman, 2015/08/07 19:37:12]

nit: indent 3 spaces so that "int" is aligned with "std::string"

[lwchkg, 2015/08/09 16:11:49]

Acknowledged.

+  profile_stats_values_.push_back(std::make_pair(category, count));
+  callback_.Run(profile_stats_values_);
+}
+
+int ProfileStatisticsAggregator::CountBookmarksFromNode(
+    const bookmarks::BookmarkNode* node) {
+  int count = 0;
+  if (node->is_url()) {
+    ++count;
+  } else {
+    for (int i = 0; i < node->child_count(); ++i)
+      count += CountBookmarksFromNode(node->GetChild(i));
+  }
+  return count;
+}
+
+int ProfileStatisticsAggregator::CountBookmarks() const {
+  bookmarks::BookmarkModel* bookmark_model =
+      BookmarkModelFactory::GetForProfileIfExists(profile_);
+
+  if (bookmark_model) {
+    return CountBookmarksFromNode(bookmark_model->bookmark_bar_node()) +
+           CountBookmarksFromNode(bookmark_model->other_node()) +
+           CountBookmarksFromNode(bookmark_model->mobile_node());
+  }
+  return 0;
+}
+
+int ProfileStatisticsAggregator::CountPrefs() const {
+  const PrefService* pref_service = profile_->GetPrefs();
+
+  if (!pref_service)
+    return 0;
+
+  scoped_ptr<base::DictionaryValue> prefs =
+      pref_service->GetPreferenceValuesWithoutPathExpansion();
+
+  int count = 0;
+  for (base::DictionaryValue::Iterator it(*(prefs.get()));
+       !it.IsAtEnd(); it.Advance()) {
+    const PrefService::Preference* pref = pref_service->
+                                              FindPreference(it.key());
+    // Skip all dictionaries (which must be empty by the function call above).
+    if (it.value().GetType() != base::Value::TYPE_DICTIONARY &&
+      pref && pref->IsUserControlled() && !pref->IsDefaultValue()) {
+      ++count;
+    }
+  }
+  return count;
+}
+
+void GetProfileStatistics(Profile* profile,
+    const ProfileStatisticsCallback& callback,
+    base::CancelableTaskTracker* tracker) {
+  new ProfileStatisticsAggregator(profile, callback, tracker);

[Mike Lerman, 2015/08/07 19:37:12]

what deletes this object?

[lwchkg, 2015/08/09 16:11:49]

This object is now RefcountedThreadSafe. This is needed for
CancelableTaskTracker to function properly.

I'll put it in a scoped_refptr (sorry for bad design here) so the object is
refcounted at least once.

+}
+
+}  // namespace profiles