Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1248573002: Add a histogram to record requestDevice outcomes. (Closed)

Created:
5 years, 5 months ago by Jeffrey Yasskin
Modified:
5 years, 5 months ago
CC:
chromium-reviews, darin-cc_chromium.org, scheib+watch_chromium.org, jam, asvitkine+watch_chromium.org, ortuno
Base URL:
https://chromium.googlesource.com/chromium/src.git@plumb-render-frame-host2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a histogram to record requestDevice outcomes. BUG=420284 Committed: https://crrev.com/e1f6f228d129a7611e98ac399e19949a11c42580 Cr-Commit-Position: refs/heads/master@{#339719}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rename to Bluetooth.RequestDevice.Outcome and fix a spelling error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -0 lines) Patch
M content/browser/bluetooth/bluetooth_dispatcher_host.cc View 1 6 chunks +25 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +21 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Jeffrey Yasskin
5 years, 5 months ago (2015-07-21 00:49:45 UTC) #2
Alexei Svitkine (slow)
lgtm https://codereview.chromium.org/1248573002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1248573002/diff/1/tools/metrics/histograms/histograms.xml#newcode2685 tools/metrics/histograms/histograms.xml:2685: +<histogram name="Bluetooth.RequestDeviceOutcome" Nit: Optional suggestion: Name it: Bluetooth.RequestDevice.Outcome ...
5 years, 5 months ago (2015-07-21 15:44:46 UTC) #3
scheib
LGTM with: https://codereview.chromium.org/1248573002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right): https://codereview.chromium.org/1248573002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc#newcode53 content/browser/bluetooth/bluetooth_dispatcher_host.cc:53: // sure to update the enum list ...
5 years, 5 months ago (2015-07-21 17:41:22 UTC) #4
Jeffrey Yasskin
https://codereview.chromium.org/1248573002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc File content/browser/bluetooth/bluetooth_dispatcher_host.cc (right): https://codereview.chromium.org/1248573002/diff/1/content/browser/bluetooth/bluetooth_dispatcher_host.cc#newcode53 content/browser/bluetooth/bluetooth_dispatcher_host.cc:53: // sure to update the enum list in tools/histogram/histograms.xml ...
5 years, 5 months ago (2015-07-21 18:02:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248573002/20001
5 years, 5 months ago (2015-07-21 18:04:22 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-21 19:36:02 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 19:49:17 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/e1f6f228d129a7611e98ac399e19949a11c42580
Cr-Commit-Position: refs/heads/master@{#339719}

Powered by Google App Engine
This is Rietveld 408576698