Hook up CryptAuthGCMManager to the enrollment and device sync managers.

Hook up CryptAuthGCMManager to the enrollment and device sync managers.

CryptAuth enrollment now performs a GCM registration if no previous registration
has been completed. GCM push messages can now trigger enrollment and device sync
attempts.

BUG=512230
TEST=unit tests

Committed: https://crrev.com/757fd84c95ee5a34252150bc3ffe8ec415f285c2
Cr-Commit-Position: refs/heads/master@{#340704}

[Tim Song, 2015-07-21 00:09:36]

Patchset #1 (id:1) has been deleted

[Tim Song, 2015-07-21 00:09:48]

tengs@chromium.org changed reviewers:
+ sacomoto@chromium.org

[sacomoto, 2015-07-27 16:56:51]

LGTM with nits.

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
File components/proximity_auth/cryptauth/cryptauth_device_manager.h (right):

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/cryptauth_device_manager.h:140: // Contains
perferences that outlive the lifetime of this object and across
nit: s/perferences/preferences/

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
File components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.cc (right):

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.cc:35:
CHECK(registration_in_progress_);
nit: Why CHECK and not DCHECK? Unit tests are always run in debug mode, right?

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
File components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.h (right):

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.h:21:
FakeCryptAuthGCMManager(const std::string& registration_id);
Use |explicit| for single argument constructors.

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.h:33: //
|registration_id|. Passing in an empty |registration_id| will simulate a
nit: s/in an/an/.

[Tim Song, 2015-07-28 16:45:19]

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
File components/proximity_auth/cryptauth/cryptauth_device_manager.h (right):

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/cryptauth_device_manager.h:140: // Contains
perferences that outlive the lifetime of this object and across
On 2015/07/27 16:56:51, sacomoto wrote:
> nit: s/perferences/preferences/

Done.

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
File components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.cc (right):

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.cc:35:
CHECK(registration_in_progress_);
On 2015/07/27 16:56:51, sacomoto wrote:
> nit: Why CHECK and not DCHECK? Unit tests are always run in debug mode, right?

Done.

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
File components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.h (right):

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.h:21:
FakeCryptAuthGCMManager(const std::string& registration_id);
On 2015/07/27 16:56:51, sacomoto wrote:
> Use |explicit| for single argument constructors.

Done.

https://codereview.chromium.org/1248533003/diff/20001/components/proximity_au...
components/proximity_auth/cryptauth/fake_cryptauth_gcm_manager.h:33: //
|registration_id|. Passing in an empty |registration_id| will simulate a
On 2015/07/27 16:56:51, sacomoto wrote:
> nit: s/in an/an/.

Done.

[Tim Song, 2015-07-28 16:45:23]

The CQ bit was checked by tengs@chromium.org

[Tim Song, 2015-07-28 16:45:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
sacomoto@chromium.org
Link to the patchset: https://codereview.chromium.org/1248533003/#ps60001
(title: "fix webui")

[commit-bot: I haz the power, 2015-07-28 16:46:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1248533003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1248533003/60001

[commit-bot: I haz the power, 2015-07-28 16:52:12]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2015-07-28 16:53:00]

Patchset 3 (id:??) landed as
https://crrev.com/757fd84c95ee5a34252150bc3ffe8ec415f285c2
Cr-Commit-Position: refs/heads/master@{#340704}