Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1248533002: Allow the shell runner to run outside of Mojo checkout. (Closed)

Created:
5 years, 5 months ago by ppi
Modified:
5 years, 5 months ago
Reviewers:
tonyg, qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Allow the shell runner to run outside of Mojo checkout. This patch allows to experiment with the shell runner outside of a mojo checkout. Currently this works only for Android, and only if the shell is already installed on the device. In the next step we can integrate download_shell_binary to pull down the shell binary from the cloud if needed. Fixes domokit/devtools#26. R=tonyg@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2c63b4cfe9c988bb63a57da840219c9b6cab0c56

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address Tony's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -12 lines) Patch
M mojo/devtools/common/mojo_shell View 1 2 chunks +35 lines, -12 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
ppi
Hi Tony or Ben, ptal.
5 years, 5 months ago (2015-07-20 22:36:08 UTC) #2
tonyg
lgtm https://codereview.chromium.org/1248533002/diff/1/mojo/devtools/common/mojo_shell File mojo/devtools/common/mojo_shell (right): https://codereview.chromium.org/1248533002/diff/1/mojo/devtools/common/mojo_shell#newcode133 mojo/devtools/common/mojo_shell:133: print 'Running with --sky is not supported outside ...
5 years, 5 months ago (2015-07-20 22:38:30 UTC) #3
ppi
https://codereview.chromium.org/1248533002/diff/1/mojo/devtools/common/mojo_shell File mojo/devtools/common/mojo_shell (right): https://codereview.chromium.org/1248533002/diff/1/mojo/devtools/common/mojo_shell#newcode133 mojo/devtools/common/mojo_shell:133: print 'Running with --sky is not supported outside of ...
5 years, 5 months ago (2015-07-20 23:36:22 UTC) #4
ppi
5 years, 5 months ago (2015-07-20 23:36:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2c63b4cfe9c988bb63a57da840219c9b6cab0c56 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698