Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 1248503004: Have Windows use _mm_rsqrt_ss too. (Closed)

Created:
5 years, 5 months ago by mtklein_C
Modified:
5 years, 5 months ago
Reviewers:
jvanverth1, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Have Windows use _mm_rsqrt_ss too. Tidy up a little while I'm in here: 1) SIMD headers are now included by SkTypes.h as appropriate. 2) _mm_cvtss_f32() is pithier and generates the same code. Looks like this is the only code checking for SSE wrong. After this CL: ~/skia (sse) $ git grep __SSE include/core/SkPreConfig.h: #if defined(__SSE4_2__) include/core/SkPreConfig.h: #elif defined(__SSE4_1__) include/core/SkPreConfig.h: #elif defined(__SSE3__) include/core/SkPreConfig.h: #elif defined(__SSE2__) every other check is in SkPreConfig.h where it belongs. This is going to affect some GMs subtly on Windows. BUG=chromium:511458 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/b9c47f996867ec885a7ede697bd1b0859b6d9301

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M include/core/SkFloatingPoint.h View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
mtklein_C
5 years, 5 months ago (2015-07-23 15:24:53 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248503004/1
5 years, 5 months ago (2015-07-23 15:29:08 UTC) #4
jvanverth1
LGTM
5 years, 5 months ago (2015-07-23 15:31:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248503004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248503004/1
5 years, 5 months ago (2015-07-23 15:34:14 UTC) #8
commit-bot: I haz the power
5 years, 5 months ago (2015-07-23 15:37:05 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/b9c47f996867ec885a7ede697bd1b0859b6d9301

Powered by Google App Engine
This is Rietveld 408576698