start to plumb ttcIndex into fonthost. For now just add to SkFontStream and its callers.

start to plumb ttcIndex into fonthost. For now just add to SkFontStream and its callers.
Committed: https://code.google.com/p/skia/source/detail?r=7998

[bungeman-skia, 2013-03-05 22:07:33]

https://codereview.chromium.org/12485002/diff/1/trunk/src/core/SkFontStream.cpp
File trunk/src/core/SkFontStream.cpp (right):

https://codereview.chromium.org/12485002/diff/1/trunk/src/core/SkFontStream.c...
trunk/src/core/SkFontStream.cpp:46: static int count_tables(SkStream* stream,
int ttcIndex, size_t* offsetToDir) {
ttcIndex may well be perfectly well served by an int, but why not unsigned?
You're already casting it to unsigned below anyway, asserting below, and
obviously it can't reasonably be negative.

https://codereview.chromium.org/12485002/diff/1/trunk/src/core/SkFontStream.c...
trunk/src/core/SkFontStream.cpp:140: return 0;
The doc says return 0 for sfnt, but this returns 0 for everything > ~20 bytes?
Just return 0 for "Doesn't look like a TTC"?

https://codereview.chromium.org/12485002/diff/1/trunk/src/ports/SkFontHost_fo...
File trunk/src/ports/SkFontHost_fontconfig.cpp (right):

https://codereview.chromium.org/12485002/diff/1/trunk/src/ports/SkFontHost_fo...
trunk/src/ports/SkFontHost_fontconfig.cpp:305: return stream.get() ?
I know it isn't as popular, but I prefer formatting like

return stream.get()
    ? SkFontStream::GetTableTags(stream, ttcIndex, tags)
    : 0

it makes the operator stand out more and looks more like a list of alternatives.
When the operator tokens are at the ends of lines they kind of get lost.

[bungeman-skia, 2013-03-05 22:11:57]

lgtm

[reed1, 2013-03-05 22:12:17]

Committed patchset #2 manually as r7998 (presubmit successful).