pkg/compiler/lib/src/ssa/builder.dart - Issue 1248483008: Split MessageKind into a MessageKind key and a MessageTemplate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 1248483008: Split MessageKind into a MessageKind key and a MessageTemplate. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Update comments. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/ssa/builder.dart

diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart

index 2928f9ee1405a9f73d05e8112b0262fd93b39dd1..0f5199287baf9082ade8007d022b1fbaabd75e3d 100644

--- a/pkg/compiler/lib/src/ssa/builder.dart

+++ b/pkg/compiler/lib/src/ssa/builder.dart

@@ -5636,7 +5636,8 @@ class SsaBuilder extends ast.Visitor

noSuchMethodTargetSymbolString(error, 'constructor'),

argumentNodes: node.send.arguments);

} else {

- Message message = error.messageKind.message(error.messageArguments);

+ MessageTemplate template = MessageTemplate.TEMPLATES[error.messageKind];

+ Message message = template.message(error.messageArguments);

generateRuntimeError(node.send, message.toString());

}

} else if (node.isConst) {