src/x64/lithium-x64.cc - Issue 1248483007: Store offset between fixed typed array base and data start in object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.cc

Issue 1248483007: Store offset between fixed typed array base and data start in object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/lithium-x64.cc

diff --git a/src/x64/lithium-x64.cc b/src/x64/lithium-x64.cc

index e41133cb0097570a60309abc6aa75e1857161a9c..46bb35ae8f9fab01007ce77bb5186f7dbb58290f 100644

--- a/src/x64/lithium-x64.cc

+++ b/src/x64/lithium-x64.cc

@@ -2332,10 +2332,7 @@ LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {

!IsDoubleOrFloatElementsKind(elements_kind)) ||

(instr->value()->representation().IsDouble() &&

IsDoubleOrFloatElementsKind(elements_kind)));

- DCHECK((instr->is_fixed_typed_array() &&

- instr->elements()->representation().IsTagged()) ||

- (instr->is_external() &&

- instr->elements()->representation().IsExternal()));

+ DCHECK(instr->elements()->representation().IsExternal());

bool val_is_temp_register =

elements_kind == EXTERNAL_UINT8_CLAMPED_ELEMENTS ||

elements_kind == EXTERNAL_FLOAT32_ELEMENTS ||

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x87/lithium-codegen-x87.cc » ('j') | no next file with comments »