src/arm64/lithium-arm64.cc - Issue 1248483007: Store offset between fixed typed array base and data start in object

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/lithium-arm64.cc

Issue 1248483007: Store offset between fixed typed array base and data start in object (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: updates Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/lithium-arm64.cc

diff --git a/src/arm64/lithium-arm64.cc b/src/arm64/lithium-arm64.cc

index f914551066411c49319d8a41899fd98ae2e028f8..e1119c2c678e4941ebb47e344ab5979dd9939a3c 100644

--- a/src/arm64/lithium-arm64.cc

+++ b/src/arm64/lithium-arm64.cc

@@ -2388,10 +2388,7 @@ LInstruction* LChunkBuilder::DoStoreKeyed(HStoreKeyed* instr) {

!IsDoubleOrFloatElementsKind(instr->elements_kind())) ||

(instr->value()->representation().IsDouble() &&

IsDoubleOrFloatElementsKind(instr->elements_kind())));

- DCHECK((instr->is_fixed_typed_array() &&

- instr->elements()->representation().IsTagged()) ||

- (instr->is_external() &&

- instr->elements()->representation().IsExternal()));

+ DCHECK(instr->elements()->representation().IsExternal());

return new(zone()) LStoreKeyedExternal(elements, key, val, temp);

} else if (instr->value()->representation().IsDouble()) {

« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/arm64/lithium-codegen-arm64.cc » ('j') | no next file with comments »