Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1248483005: Add use counter for stacked neutral keyframe in CSS Animations (Closed)

Created:
5 years, 5 months ago by alancutter (OOO until 2018)
Modified:
5 years, 4 months ago
Reviewers:
dstockwell, shans
CC:
darktears, blink-reviews, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, shans
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add use counter for stacked neutral keyframe in CSS Animations This use counter tracks whenever a page starts multiple CSS animations on an element where the tail animations include neutral keyframes. This is to gauge the occurrence of this in the wild to determine the viability of altering the behaviour in a subset of these cases. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200692

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review changes and rebase #

Patch Set 3 : Call release() #

Patch Set 4 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -3 lines) Patch
A LayoutTests/animations/use-count-stacked-neutral-keyframe.html View 1 2 3 1 chunk +31 lines, -0 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 2 3 4 chunks +5 lines, -3 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
alancutter (OOO until 2018)
5 years, 5 months ago (2015-07-21 00:38:06 UTC) #2
alancutter (OOO until 2018)
shans dstockwell: Poke.
5 years, 5 months ago (2015-07-27 01:22:22 UTC) #3
shans
https://codereview.chromium.org/1248483005/diff/1/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/1248483005/diff/1/Source/core/animation/css/CSSAnimations.cpp#newcode266 Source/core/animation/css/CSSAnimations.cpp:266: createKeyframeEffectModel(resolver, animatingElement, element, &style, parentStyle, animationName, keyframeTimingFunction.get(), i), It'd ...
5 years, 4 months ago (2015-08-06 05:09:30 UTC) #4
alancutter (OOO until 2018)
https://codereview.chromium.org/1248483005/diff/1/Source/core/animation/css/CSSAnimations.cpp File Source/core/animation/css/CSSAnimations.cpp (right): https://codereview.chromium.org/1248483005/diff/1/Source/core/animation/css/CSSAnimations.cpp#newcode266 Source/core/animation/css/CSSAnimations.cpp:266: createKeyframeEffectModel(resolver, animatingElement, element, &style, parentStyle, animationName, keyframeTimingFunction.get(), i), On ...
5 years, 4 months ago (2015-08-06 07:10:08 UTC) #5
dstockwell
lgtm
5 years, 4 months ago (2015-08-17 07:42:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248483005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248483005/40001
5 years, 4 months ago (2015-08-17 07:43:38 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/57246) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 4 months ago (2015-08-17 07:45:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248483005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1248483005/60001
5 years, 4 months ago (2015-08-18 01:57:55 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 04:32:13 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200692

Powered by Google App Engine
This is Rietveld 408576698