Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1248483002: clang/win: Fix another -Wunused-local-typedef warning. (Closed)

Created:
5 years, 5 months ago by Nico
Modified:
5 years, 5 months ago
Reviewers:
robertshield
CC:
chromium-reviews, grt+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Fix another -Wunused-local-typedef warning. Fixes ..\..\chrome/installer/mini_installer/mini_string.h(77,36) : error: unused typedef 'invalid_buffer_size' [-Werror,-Wunused-local-typedef] COMPILE_ASSERT(kCapacity != 0, invalid_buffer_size); ^ ..\..\chrome/installer/mini_installer/mini_string.h(13,41) : note: expanded from macro 'COMPILE_ASSERT' typedef CompileAssert<(bool(expr))> msg[bool(expr) ? 1 : -1] ^ BUG=411648 TBR=robertshield Committed: https://crrev.com/c1417ea468bf47c3359f39fff0e0aa3fee6390a4 Cr-Commit-Position: refs/heads/master@{#339541}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -5 lines) Patch
M chrome/installer/mini_installer/mini_string.h View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Nico
5 years, 5 months ago (2015-07-20 21:04:34 UTC) #1
Nico
(looks like this intentionally doesn't depend on base)
5 years, 5 months ago (2015-07-20 21:04:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248483002/1
5 years, 5 months ago (2015-07-20 21:05:04 UTC) #4
robertshield
Lgtm, and yes not depending on base is intentional here.
5 years, 5 months ago (2015-07-20 22:06:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-20 22:38:01 UTC) #6
commit-bot: I haz the power
5 years, 5 months ago (2015-07-20 22:39:01 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c1417ea468bf47c3359f39fff0e0aa3fee6390a4
Cr-Commit-Position: refs/heads/master@{#339541}

Powered by Google App Engine
This is Rietveld 408576698