Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: components/autofill/ios/browser/js_autofill_manager.mm

Issue 1248463002: Eliminate the use of autofill::REQUIRE_AUTOCOMPLETE [step 3 of 3]. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/ios/browser/js_autofill_manager.mm
diff --git a/components/autofill/ios/browser/js_autofill_manager.mm b/components/autofill/ios/browser/js_autofill_manager.mm
index 3a84762e818f36368f3b8ddc316e336fb01c749a..e44e3b340554ed22486386197e934c5717bfabca 100644
--- a/components/autofill/ios/browser/js_autofill_manager.mm
+++ b/components/autofill/ios/browser/js_autofill_manager.mm
@@ -13,31 +13,10 @@
- (void)fetchFormsWithMinimumRequiredFieldsCount:(NSUInteger)requiredFieldsCount
completionHandler:
(void (^)(NSString*))completionHandler {
- [self fetchFormsWithRequirements:autofill::REQUIRE_NONE
- minimumRequiredFieldsCount:requiredFieldsCount
- completionHandler:completionHandler];
-}
-
-- (void)fetchFormsWithRequirements:(autofill::RequirementsMask)requirements
- minimumRequiredFieldsCount:(NSUInteger)requiredFieldsCount
- completionHandler:(void (^)(NSString*))completionHandler {
DCHECK(completionHandler);
- // Convert from C++ enum to JS enum.
- NSString* requirementsJS = nil;
- switch (requirements) {
- case autofill::REQUIRE_NONE:
- requirementsJS = @"__gCrWeb.autofill.REQUIREMENTS_MASK_NONE";
- break;
- case autofill::REQUIRE_AUTOCOMPLETE:
- requirementsJS =
- @"__gCrWeb.autofill.REQUIREMENTS_MASK_REQUIRE_AUTOCOMPLETE";
- break;
- }
- DCHECK(requirementsJS);
-
NSString* extractFormsJS = [NSString
- stringWithFormat:@"__gCrWeb.autofill.extractForms(%" PRIuNS ", %@);",
- requiredFieldsCount, requirementsJS];
+ stringWithFormat:@"__gCrWeb.autofill.extractForms(%" PRIuNS ");",
+ requiredFieldsCount];
[self evaluate:extractFormsJS
stringResultHandler:^(NSString* result, NSError*) {
completionHandler(result);

Powered by Google App Engine
This is Rietveld 408576698