Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1248463002: Eliminate the use of autofill::REQUIRE_AUTOCOMPLETE [step 3 of 3]. (Closed)

Created:
5 years, 5 months ago by Justin Donnelly
Modified:
5 years, 5 months ago
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Eliminate the use of autofill::REQUIRE_AUTOCOMPLETE [step 3 of 3]. - Step 1: Upstream: add a new JsAutofillManager method that doesn't require a autofill::RequirementsMask parameter. - Step 2: Downstream: use the new method. - Step 3: This change. NOTE: landing this change requires waiting for https://chromereviews.googleplex.com/222467014/ to land (currently blocked on problem with try bots). BUG=459456 Committed: https://crrev.com/6433d84f982c388dca67126cd5ec6a83c1a0136d Cr-Commit-Position: refs/heads/master@{#339678}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -161 lines) Patch
M components/autofill/core/common/autofill_constants.h View 1 chunk +0 lines, -7 lines 0 comments Download
M components/autofill/ios/browser/js_autofill_manager.h View 1 chunk +0 lines, -9 lines 0 comments Download
M components/autofill/ios/browser/js_autofill_manager.mm View 1 chunk +2 lines, -23 lines 0 comments Download
M components/autofill/ios/browser/resources/autofill_controller.js View 23 chunks +27 lines, -122 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Justin Donnelly
5 years, 5 months ago (2015-07-20 20:33:17 UTC) #2
Justin Donnelly
estade for components/autofill/core/common.
5 years, 5 months ago (2015-07-20 20:35:30 UTC) #4
stuartmorgan
lgtm
5 years, 5 months ago (2015-07-20 21:00:00 UTC) #5
Evan Stade
lgtm
5 years, 5 months ago (2015-07-20 21:01:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1248463002/1
5 years, 5 months ago (2015-07-21 17:07:57 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 5 months ago (2015-07-21 17:19:08 UTC) #9
commit-bot: I haz the power
5 years, 5 months ago (2015-07-21 17:21:00 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6433d84f982c388dca67126cd5ec6a83c1a0136d
Cr-Commit-Position: refs/heads/master@{#339678}

Powered by Google App Engine
This is Rietveld 408576698