Source/platform/fonts/shaping/CachingWordShaper.cpp - Issue 1248453004: Change Font::offsetForPositionForComplexText to use CachingWordShapeIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/shaping/CachingWordShaper.cpp

Issue 1248453004: Change Font::offsetForPositionForComplexText to use CachingWordShapeIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: TestExpectations and rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/platform/fonts/shaping/CachingWordShaper.h ('k') | Source/platform/fonts/shaping/HarfBuzzShaper.h » ('j') | Source/platform/fonts/shaping/HarfBuzzShaper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/shaping/CachingWordShaper.cpp

diff --git a/Source/platform/fonts/shaping/CachingWordShaper.cpp b/Source/platform/fonts/shaping/CachingWordShaper.cpp

index b9b2d77c9bad48c9dcf3cb0b6bdb9bb6fc0b6e61..087f885a193ca239553ae833b4cf7237c163e99c 100644

--- a/Source/platform/fonts/shaping/CachingWordShaper.cpp

+++ b/Source/platform/fonts/shaping/CachingWordShaper.cpp

@@ -68,6 +68,13 @@ float CachingWordShaper::width(const Font* font, const TextRun& run,

return width;

}

+int CachingWordShaper::offsetForPosition(const Font* font, const TextRun& run, float targetX)

+ HashSet<const SimpleFontData*> fallbackFonts;

+ CachingWordShapeIterator iterator(m_shapeCache, run, font, &fallbackFonts);

+ return ShapeResult::offsetForPosition(iterator, run, targetX);

static inline float shapeResultsForRun(ShapeCache* shapeCache, const Font* font,

const TextRun& run, HashSet<const SimpleFontData*>* fallbackFonts,

Vector<RefPtr<ShapeResult>>* results)