Source/platform/fonts/Font.cpp - Issue 1248453004: Change Font::offsetForPositionForComplexText to use CachingWordShapeIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/Font.cpp

Issue 1248453004: Change Font::offsetForPositionForComplexText to use CachingWordShapeIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: TestExpectations and rebase Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/editing/selection/offset-from-point-expected.txt ('k') | Source/platform/fonts/shaping/CachingWordShaper.h » ('j') | Source/platform/fonts/shaping/HarfBuzzShaper.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/platform/fonts/Font.cpp

diff --git a/Source/platform/fonts/Font.cpp b/Source/platform/fonts/Font.cpp

index fcf0d6448827e7020f7a94cd709879e699c2c9b5..e2c4e119c2603efea92499af169c276a758b2d32 100644

--- a/Source/platform/fonts/Font.cpp

+++ b/Source/platform/fonts/Font.cpp

@@ -707,12 +707,8 @@ float Font::floatWidthForComplexText(const TextRun& run, HashSet<const SimpleFon

int Font::offsetForPositionForComplexText(const TextRun& run, float xFloat,

bool includePartialGlyphs) const

{

- HashSet<const SimpleFontData*> fallbackFonts;

- HarfBuzzShaper shaper(this, run, &fallbackFonts);

- RefPtr<ShapeResult> shapeResult = shaper.shapeResult();

- if (!shapeResult)

- return 0;

- return shapeResult->offsetForPosition(xFloat);

+ CachingWordShaper& shaper = m_fontFallbackList->cachingWordShaper();

+ return shaper.offsetForPosition(this, run, xFloat);

}

// Return the rectangle for selecting the given range of code-points in the TextRun.