Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1152)

Unified Diff: media/filters/source_buffer_stream.cc

Issue 1248453003: MSE: Provide link in media-internals to known bug 229412 until it is fixed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix nit (++positivity_and_helpfulness_of_message) Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/filters/source_buffer_stream.cc
diff --git a/media/filters/source_buffer_stream.cc b/media/filters/source_buffer_stream.cc
index 32328dac273365b359f53ed1b401a6b95f4e45e9..b8077aa50cee12d732498121a899104895849445 100644
--- a/media/filters/source_buffer_stream.cc
+++ b/media/filters/source_buffer_stream.cc
@@ -239,8 +239,10 @@ bool SourceBufferStream::Append(const BufferQueue& buffers) {
// New media segments must begin with a keyframe.
// TODO(wolenetz): Relax this requirement. See http://crbug.com/229412.
if (new_media_segment_ && !buffers.front()->is_key_frame()) {
- MEDIA_LOG(ERROR, media_log_)
- << "Media segment did not begin with key frame.";
+ MEDIA_LOG(ERROR, media_log_) << "Media segment did not begin with key "
+ "frame. Support for such segments will be "
+ "available in a future version. Please see "
+ "https://crbug.com/229412.";
return false;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698