Issue 124833004: Translate New UX: Show bubble when clicking the icon within an automatic translate session

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 124833004: Translate New UX: Show bubble when clicking the icon within an automatic translate session (Closed)

Created:
6 years, 11 months ago by hajimehoshi

Modified:
6 years, 11 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Translate New UX: Show bubble when clicking the icon within an automatic translate session Moved the 'if' clause to check if the translation is performed automatically to TranslateManager. TranslateBubbleView::ShowBubble is called not only from TranslateManager but also when the user clicks the icon explicitly. In the latter case, the translate bubble should be shown whether the automatic translation is done or not. BUG=330684 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243502

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -11 lines)			Patch
	M	chrome/browser/translate/translate_manager.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/translate/translate_bubble_view.cc	View		1 chunk	+0 lines, -11 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/124833004/1

6 years, 11 months ago (2014-01-07 09:59:32 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=242334

6 years, 11 months ago (2014-01-07 12:26:09 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hajimehoshi@chromium.org/124833004/1

6 years, 11 months ago (2014-01-08 02:34:32 UTC) #5

Message was sent while issue was closed.

Change committed as 243502

Expand Messages | Collapse Messages