Source/core/loader/MixedContentChecker.cpp - Issue 1248313002: Add a setting to strictly block "blockable" mixed content.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/loader/MixedContentChecker.cpp

Issue 1248313002: Add a setting to strictly block "blockable" mixed content. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: yoav Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/loader/MixedContentChecker.cpp

diff --git a/Source/core/loader/MixedContentChecker.cpp b/Source/core/loader/MixedContentChecker.cpp

index 9419f5c8fe44de72b53117a5c6335a2113d3540b..39c7ce752e68e99d9e4d2c3e2dde2585fd07e502 100644

--- a/Source/core/loader/MixedContentChecker.cpp

+++ b/Source/core/loader/MixedContentChecker.cpp

@@ -323,7 +323,7 @@ bool MixedContentChecker::shouldBlockFetch(LocalFrame* frame, WebURLRequest::Req

break;

case ContextTypeBlockable:

- allowed = !strictMode && client->allowRunningInsecureContent(settings && settings->allowRunningOfInsecureContent(), securityOrigin, url);

+ allowed = !strictMode && !settings->strictlyBlockBlockableMixedContent() && client->allowRunningInsecureContent(settings && settings->allowRunningOfInsecureContent(), securityOrigin, url);

if (allowed) {

client->didRunInsecureContent(securityOrigin, url);

UseCounter::count(mixedFrame, UseCounter::MixedContentBlockableAllowed);

« no previous file with comments | « Source/core/frame/Settings.in ('k') | Source/web/WebSettingsImpl.h » ('j') | no next file with comments »