src/x64/macro-assembler-x64.cc - Issue 1248303002: Unify runtime-style IC functions with Runtime intrinsics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/macro-assembler-x64.cc

Issue 1248303002: Unify runtime-style IC functions with Runtime intrinsics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Review feedback Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/macro-assembler-x64.cc

diff --git a/src/x64/macro-assembler-x64.cc b/src/x64/macro-assembler-x64.cc

index 63928797fecc434294bbb76de6e6e2f2e81a06f8..b1b02aa77bad1da99d9095de4dc64f06699d0502 100644

--- a/src/x64/macro-assembler-x64.cc

+++ b/src/x64/macro-assembler-x64.cc

@@ -3555,7 +3555,8 @@ void MacroAssembler::DecrementCounter(StatsCounter* counter, int value) {

void MacroAssembler::DebugBreak() {

Set(rax, 0); // No arguments.

- LoadAddress(rbx, ExternalReference(Runtime::kDebugBreak, isolate()));

+ LoadAddress(rbx,

+ ExternalReference(Runtime::kHandleDebuggerStatement, isolate()));

CEntryStub ces(isolate(), 1);

DCHECK(AllowThisStubCall(&ces));

Call(ces.GetCode(), RelocInfo::DEBUGGER_STATEMENT);