Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: src/arm/code-stubs-arm.cc

Issue 1248303002: Unify runtime-style IC functions with Runtime intrinsics (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Review feedback Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/arm/code-stubs-arm.cc
diff --git a/src/arm/code-stubs-arm.cc b/src/arm/code-stubs-arm.cc
index a3360ea2165ee332757b9a8d926c7c416cc3198f..dd4a54429b10a10e0fbd6e60b8c2362479590f68 100644
--- a/src/arm/code-stubs-arm.cc
+++ b/src/arm/code-stubs-arm.cc
@@ -1838,8 +1838,9 @@ void LoadIndexedInterceptorStub::Generate(MacroAssembler* masm) {
// Perform tail call to the entry.
__ TailCallExternalReference(
- ExternalReference(IC_Utility(IC::kLoadElementWithInterceptor),
- masm->isolate()),
+ ExternalReference(
+ Runtime::FunctionForId(Runtime::kLoadElementWithInterceptor),
+ masm->isolate()),
2, 1);
__ bind(&slow);
@@ -2906,10 +2907,12 @@ void CallICStub::GenerateMiss(MacroAssembler* masm) {
__ Push(r1, r2, r3);
// Call the entry.
- IC::UtilityId id = GetICState() == DEFAULT ? IC::kCallIC_Miss
- : IC::kCallIC_Customization_Miss;
+ Runtime::FunctionId id = GetICState() == DEFAULT
+ ? Runtime::kCallIC_Miss
+ : Runtime::kCallIC_Customization_Miss;
- ExternalReference miss = ExternalReference(IC_Utility(id), masm->isolate());
+ ExternalReference miss =
+ ExternalReference(Runtime::FunctionForId(id), masm->isolate());
__ CallExternalReference(miss, 3);
// Move result to edi and exit the internal frame.
@@ -3821,8 +3824,8 @@ void CompareICStub::GenerateKnownObjects(MacroAssembler* masm) {
void CompareICStub::GenerateMiss(MacroAssembler* masm) {
{
// Call the runtime system in a fresh internal frame.
- ExternalReference miss =
- ExternalReference(IC_Utility(IC::kCompareIC_Miss), isolate());
+ ExternalReference miss = ExternalReference(
+ Runtime::FunctionForId(Runtime::kCompareIC_Miss), isolate());
FrameAndConstantPoolScope scope(masm, StackFrame::INTERNAL);
__ Push(r1, r0);
« no previous file with comments | « src/arguments.h ('k') | src/arm/debug-arm.cc » ('j') | src/arm64/code-stubs-arm64.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698