Add better support for RGBA_4444 textures.

cc/raster/tile_task_worker_pool.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/raster/tile_task_worker_pool.h"
 
 #include <algorithm>
 
 #include "base/trace_event/trace_event.h"
 #include "cc/playback/raster_source.h"
@@ skipping 206 matching lines @@
     canvas->setDrawFilter(image_filter.get());
     raster_source->PlaybackToCanvas(canvas.get(), canvas_bitmap_rect,
                                     canvas_playback_rect, scale);
     return;
   }
 
   skia::RefPtr<SkSurface> surface =
       skia::AdoptRef(SkSurface::NewRaster(info, &surface_props));
   skia::RefPtr<SkCanvas> canvas = skia::SharePtr(surface->getCanvas());
   canvas->setDrawFilter(image_filter.get());
+  // TODO(reveman): Improve partial raster support by reducing the size of
+  // playback rect passed to PlaybackToCanvas. crbug.com/519070
   raster_source->PlaybackToCanvas(canvas.get(), canvas_bitmap_rect,
-                                  canvas_playback_rect, scale);
+                                  canvas_bitmap_rect, scale);
 
-  SkImageInfo dst_info =
-      SkImageInfo::Make(info.width(), info.height(), buffer_color_type,
-                        info.alphaType(), info.profileType());
-  // TODO(kaanb): The GL pipeline assumes a 4-byte alignment for the
-  // bitmap data. There will be no need to call SkAlign4 once crbug.com/293728
-  // is fixed.
-  const size_t dst_row_bytes = SkAlign4(dst_info.minRowBytes());
-  DCHECK_EQ(0u, dst_row_bytes % 4);
-  bool success = canvas->readPixels(dst_info, memory, dst_row_bytes, 0, 0);
-  DCHECK_EQ(true, success);
+  {
+    TRACE_EVENT0("cc", "TileTaskWorkerPool::PlaybackToMemory::ConvertPixels");

[vmpstr, 2015/08/11 17:46:17]

nit: can you add a trace at the top of the function as well, so that we can tell
what's PlaybackToMemory taking and what portion of that is ConvertPixels

[reveman, 2015/08/11 18:11:29]

Done.

+
+    SkImageInfo dst_info =
+        SkImageInfo::Make(info.width(), info.height(), buffer_color_type,
+                          info.alphaType(), info.profileType());
+    // TODO(kaanb): The GL pipeline assumes a 4-byte alignment for the
+    // bitmap data. There will be no need to call SkAlign4 once crbug.com/293728
+    // is fixed.
+    const size_t dst_row_bytes = SkAlign4(dst_info.minRowBytes());
+    DCHECK_EQ(0u, dst_row_bytes % 4);
+    bool success = canvas->readPixels(dst_info, memory, dst_row_bytes, 0, 0);
+    DCHECK_EQ(true, success);
+  }
 }
 
 }  // namespace cc