Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 1248213002: allow await to be any value, fixes part of #264 (Closed)

Created:
5 years, 5 months ago by Jennifer Messerly
Modified:
5 years, 5 months ago
Reviewers:
vsm, Leaf, kevmoo
CC:
dev-compiler+reviews_dartlang.org, kevmoo
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

allow await to be any value, fixes part of #264 Committed: https://github.com/dart-lang/dev_compiler/commit/76b257bf3c5acec2346c86f26049e934bd9dd7eb

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -9 lines) Patch
M lib/src/checker/checker.dart View 1 1 chunk +0 lines, -6 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/checker/checker_test.dart View 1 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Jennifer Messerly
fyi, this was in my async/await CL, but since Kevin hit it, here's one that ...
5 years, 5 months ago (2015-07-22 23:02:34 UTC) #2
kevmoo
lgtm
5 years, 5 months ago (2015-07-22 23:04:44 UTC) #4
Jennifer Messerly
5 years, 5 months ago (2015-07-22 23:06:35 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
76b257bf3c5acec2346c86f26049e934bd9dd7eb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698