[Mac] added support for show as tab on popups, similar behavior that exists in windows in which rep…

[Mac] added support for show as tab on popups, similar behavior that exists in windows in which replaces 'New Tab' with 'Show as tab' except now in file menu instead of right click on menu bar


BUG=43953
TEST=Start Chrome and go to some website to launch a popup.  Can easily make a test with <a href="JavaScript:newPopup('about:blank');">Test</a>.  The new popup should have 'Show as Tab' instead of 'New Tab' in the File menu where all other windows should behave as normal. When clicking the 'Show as Tab' it should create a new window with it as a tab which can be dragged into the original window, which is the same behaviour as on Window.

[bryjeep, 2015-07-22 22:23:08]

bryjeep@gmail.com changed reviewers:
+ avi@chromium.org

[bryjeep, 2015-07-22 22:23:08]

I have added avi@chromium.org as blame shows he made modifications to a nearby
section and /chrome/browser/ui/cocoa/OWNERS shows him in the list. This is my
first contribution so let me know anything else I need to do.

I see that in /chrome/app/OWNERS  that I need to file a bug with google to get
the string approved as I followed the convention that the rest of the MAC cocoa
code and created a IDS_SHOW_AS_TAB_MAC like all the IDS_*_MAC but it same string
as other platform so will also do that.

[bryjeep, 2015-07-22 22:51:55]

bryjeep@gmail.com changed reviewers:
+ tapted@chromium.org

[bryjeep, 2015-07-22 22:55:09]

bryjeep@gmail.com changed reviewers:
+ grt@chromium.org

[Avi (use Gerrit), 2015-07-23 00:50:21]

On 2015/07/22 22:23:08, bryjeep wrote:
> I have added mailto:avi@chromium.org as blame shows he made modifications to a
nearby
> section and /chrome/browser/ui/cocoa/OWNERS shows him in the list. This is my
> first contribution so let me know anything else I need to do.
> 
> I see that in /chrome/app/OWNERS  that I need to file a bug with google to get
> the string approved as I followed the convention that the rest of the MAC
cocoa
> code and created a IDS_SHOW_AS_TAB_MAC like all the IDS_*_MAC but it same
string
> as other platform so will also do that.

I asked for UI review on your bug.

Some issues. First, I googled up a page that opened popups to test it, and every
time I tried to do the window conversion it worked but both tabs immediately
crashed. I can't repro again, but can you test this?

Second:
- Open a page that has a popup link
- Click it to make a popup
- Close the original page
- Close the popup (without converting it)

That leaves the "convert to tab" in the file menu.