Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(765)

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 1248113003: VM: Fix more places with isolate embedded into unoptimized code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: minor cleanup in stub_code* Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intrinsifier_ia32.cc
diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc
index f2bb2568feefaba46c139e69e604ad47ab879594..df92379a733e636022ab1d333ff4c304a8f5c671 100644
--- a/runtime/vm/intrinsifier_ia32.cc
+++ b/runtime/vm/intrinsifier_ia32.cc
@@ -2116,45 +2116,32 @@ void Intrinsifier::JSRegExp_ExecuteMatch(Assembler* assembler) {
// On stack: user tag (+1), return-address (+0).
void Intrinsifier::UserTag_makeCurrent(Assembler* assembler) {
- Isolate* isolate = Isolate::Current();
- const Address current_tag_addr =
- Address::Absolute(reinterpret_cast<uword>(isolate) +
- Isolate::current_tag_offset());
- const Address user_tag_addr =
- Address::Absolute(reinterpret_cast<uword>(isolate) +
- Isolate::user_tag_offset());
+ // RDI: Isolate.
+ __ LoadIsolate(EDI);
// EAX: Current user tag.
- __ movl(EAX, current_tag_addr);
+ __ movl(EAX, Address(EDI, Isolate::current_tag_offset()));
// EAX: UserTag.
__ movl(EBX, Address(ESP, + 1 * kWordSize));
// Set Isolate::current_tag_.
- __ movl(current_tag_addr, EBX);
+ __ movl(Address(EDI, Isolate::current_tag_offset()), EBX);
// EAX: UserTag's tag.
__ movl(EBX, FieldAddress(EBX, UserTag::tag_offset()));
// Set Isolate::user_tag_.
- __ movl(user_tag_addr, EBX);
+ __ movl(Address(EDI, Isolate::user_tag_offset()), EBX);
__ ret();
}
void Intrinsifier::UserTag_defaultTag(Assembler* assembler) {
- Isolate* isolate = Isolate::Current();
- const Address default_tag_addr =
- Address::Absolute(
- reinterpret_cast<uword>(isolate) + Isolate::default_tag_offset());
- // Set return value.
- __ movl(EAX, default_tag_addr);
+ __ LoadIsolate(EAX);
+ __ movl(EAX, Address(EAX, Isolate::default_tag_offset()));
__ ret();
}
void Intrinsifier::Profiler_getCurrentTag(Assembler* assembler) {
- Isolate* isolate = Isolate::Current();
- const Address current_tag_addr =
- Address::Absolute(reinterpret_cast<uword>(isolate) +
- Isolate::current_tag_offset());
- // Set return value to Isolate::current_tag_.
- __ movl(EAX, current_tag_addr);
+ __ LoadIsolate(EAX);
+ __ movl(EAX, Address(EAX, Isolate::current_tag_offset()));
__ ret();
}

Powered by Google App Engine
This is Rietveld 408576698