Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: runtime/vm/stub_code_ia32.cc

Issue 1248113003: VM: Fix more places with isolate embedded into unoptimized code. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: minor cleanup in stub_code* Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/compiler.h" 9 #include "vm/compiler.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 1949 matching lines...) Expand 10 before | Expand all | Expand 10 after
1960 BigintCompare, 1960 BigintCompare,
1961 RawBigint* left, 1961 RawBigint* left,
1962 RawBigint* right); 1962 RawBigint* right);
1963 1963
1964 1964
1965 // Does identical check (object references are equal or not equal) with special 1965 // Does identical check (object references are equal or not equal) with special
1966 // checks for boxed numbers. 1966 // checks for boxed numbers.
1967 // Return ZF set. 1967 // Return ZF set.
1968 // Note: A Mint cannot contain a value that would fit in Smi, a Bigint 1968 // Note: A Mint cannot contain a value that would fit in Smi, a Bigint
1969 // cannot contain a value that fits in Mint or Smi. 1969 // cannot contain a value that fits in Mint or Smi.
1970 void StubCode::GenerateIdenticalWithNumberCheckStub(Assembler* assembler, 1970 static void GenerateIdenticalWithNumberCheckStub(Assembler* assembler,
1971 const Register left, 1971 const Register left,
1972 const Register right, 1972 const Register right,
1973 const Register temp, 1973 const Register temp) {
1974 const Register unused) {
1975 Label reference_compare, done, check_mint, check_bigint; 1974 Label reference_compare, done, check_mint, check_bigint;
1976 // If any of the arguments is Smi do reference compare. 1975 // If any of the arguments is Smi do reference compare.
1977 __ testl(left, Immediate(kSmiTagMask)); 1976 __ testl(left, Immediate(kSmiTagMask));
1978 __ j(ZERO, &reference_compare, Assembler::kNearJump); 1977 __ j(ZERO, &reference_compare, Assembler::kNearJump);
1979 __ testl(right, Immediate(kSmiTagMask)); 1978 __ testl(right, Immediate(kSmiTagMask));
1980 __ j(ZERO, &reference_compare, Assembler::kNearJump); 1979 __ j(ZERO, &reference_compare, Assembler::kNearJump);
1981 1980
1982 // Value compare for two doubles. 1981 // Value compare for two doubles.
1983 __ CompareClassId(left, kDoubleCid, temp); 1982 __ CompareClassId(left, kDoubleCid, temp);
1984 __ j(NOT_EQUAL, &check_mint, Assembler::kNearJump); 1983 __ j(NOT_EQUAL, &check_mint, Assembler::kNearJump);
(...skipping 142 matching lines...) Expand 10 before | Expand all | Expand 10 after
2127 // EBX: entry point. 2126 // EBX: entry point.
2128 void StubCode::GenerateMegamorphicLookupStub(Assembler* assembler) { 2127 void StubCode::GenerateMegamorphicLookupStub(Assembler* assembler) {
2129 EmitMegamorphicLookup(assembler, EDI, EBX, EBX); 2128 EmitMegamorphicLookup(assembler, EDI, EBX, EBX);
2130 __ ret(); 2129 __ ret();
2131 } 2130 }
2132 2131
2133 2132
2134 } // namespace dart 2133 } // namespace dart
2135 2134
2136 #endif // defined TARGET_ARCH_IA32 2135 #endif // defined TARGET_ARCH_IA32
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698